third_party/WebKit/Source/platform/fonts/SimpleFontData.cpp - Issue 1844223002: Literal AtomicString construction can rely on strlen optimization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/SimpleFontData.cpp

Issue 1844223002: Literal AtomicString construction can rely on strlen optimization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/fonts/AlternateFontFamily.h ('k') | third_party/WebKit/Source/platform/fonts/mac/FontCacheMac.mm » ('j') | third_party/WebKit/Source/wtf/text/AtomicString.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/SimpleFontData.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/SimpleFontData.cpp b/third_party/WebKit/Source/platform/fonts/SimpleFontData.cpp

index 1e18e2b2516e9e7b9c7c22ffd9c237d27f20f7da..f7d013cac6da133afc2f96b7e1e61ab10ba2ae34 100644

--- a/third_party/WebKit/Source/platform/fonts/SimpleFontData.cpp

+++ b/third_party/WebKit/Source/platform/fonts/SimpleFontData.cpp

@@ -156,9 +156,9 @@ void SimpleFontData::platformInit()

// web standard. The AppKit adjustment of 20% is too big and is

// incorrectly added to line spacing, so we use a 15% adjustment instead

// and add it to the ascent.

- DEFINE_STATIC_LOCAL(AtomicString, timesName, ("Times", AtomicString::ConstructFromLiteral));

- DEFINE_STATIC_LOCAL(AtomicString, helveticaName, ("Helvetica", AtomicString::ConstructFromLiteral));

- DEFINE_STATIC_LOCAL(AtomicString, courierName, ("Courier", AtomicString::ConstructFromLiteral));

+ DEFINE_STATIC_LOCAL(AtomicString, timesName, ("Times"));

+ DEFINE_STATIC_LOCAL(AtomicString, helveticaName, ("Helvetica"));

+ DEFINE_STATIC_LOCAL(AtomicString, courierName, ("Courier"));

String familyName = m_platformData.fontFamilyName();

if (familyName == timesName || familyName == helveticaName || familyName == courierName)

ascent += floorf(((ascent + descent) * 0.15f) + 0.5f);