third_party/WebKit/Source/modules/screen_orientation/ScreenOrientation.cpp - Issue 1844223002: Literal AtomicString construction can rely on strlen optimization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/screen_orientation/ScreenOrientation.cpp

Issue 1844223002: Literal AtomicString construction can rely on strlen optimization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp ('k') | third_party/WebKit/Source/platform/exported/linux/WebFontInfo.cpp » ('j') | third_party/WebKit/Source/wtf/text/AtomicString.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/screen_orientation/ScreenOrientation.cpp

diff --git a/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientation.cpp b/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientation.cpp

index 616b95146e21cf070d1567b17f400d3cc3a06947..359ff659dba1cf327e107b68a124cf61704df8da 100644

--- a/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientation.cpp

+++ b/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientation.cpp

@@ -33,14 +33,14 @@ struct ScreenOrientationInfo {

static ScreenOrientationInfo* orientationsMap(unsigned& length)

{

- DEFINE_STATIC_LOCAL(const AtomicString, portraitPrimary, ("portrait-primary", AtomicString::ConstructFromLiteral));

- DEFINE_STATIC_LOCAL(const AtomicString, portraitSecondary, ("portrait-secondary", AtomicString::ConstructFromLiteral));

- DEFINE_STATIC_LOCAL(const AtomicString, landscapePrimary, ("landscape-primary", AtomicString::ConstructFromLiteral));

- DEFINE_STATIC_LOCAL(const AtomicString, landscapeSecondary, ("landscape-secondary", AtomicString::ConstructFromLiteral));

- DEFINE_STATIC_LOCAL(const AtomicString, any, ("any", AtomicString::ConstructFromLiteral));

- DEFINE_STATIC_LOCAL(const AtomicString, portrait, ("portrait", AtomicString::ConstructFromLiteral));

- DEFINE_STATIC_LOCAL(const AtomicString, landscape, ("landscape", AtomicString::ConstructFromLiteral));

- DEFINE_STATIC_LOCAL(const AtomicString, natural, ("natural", AtomicString::ConstructFromLiteral));

+ DEFINE_STATIC_LOCAL(const AtomicString, portraitPrimary, ("portrait-primary"));

+ DEFINE_STATIC_LOCAL(const AtomicString, portraitSecondary, ("portrait-secondary"));

+ DEFINE_STATIC_LOCAL(const AtomicString, landscapePrimary, ("landscape-primary"));

+ DEFINE_STATIC_LOCAL(const AtomicString, landscapeSecondary, ("landscape-secondary"));

+ DEFINE_STATIC_LOCAL(const AtomicString, any, ("any"));

+ DEFINE_STATIC_LOCAL(const AtomicString, portrait, ("portrait"));

+ DEFINE_STATIC_LOCAL(const AtomicString, landscape, ("landscape"));

+ DEFINE_STATIC_LOCAL(const AtomicString, natural, ("natural"));

static ScreenOrientationInfo orientationMap[] = {

{ portraitPrimary, WebScreenOrientationLockPortraitPrimary },