third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp - Issue 1844223002: Literal AtomicString construction can rely on strlen optimization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp

Issue 1844223002: Literal AtomicString construction can rely on strlen optimization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/mediasource/TrackDefault.cpp ('k') | third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp » ('j') | third_party/WebKit/Source/wtf/text/AtomicString.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp

diff --git a/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp b/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp

index 9c1ee108543ccd58d1d60846d85f114b00c67342..44d0d280a26a8485bba3652745d7e619e5c37eb0 100644

--- a/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp

+++ b/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp

@@ -45,9 +45,9 @@ WebPresentationClient* presentationClient(ExecutionContext* executionContext)

const AtomicString& connectionStateToString(WebPresentationConnectionState state)

{

- DEFINE_STATIC_LOCAL(const AtomicString, connectedValue, ("connected", AtomicString::ConstructFromLiteral));

- DEFINE_STATIC_LOCAL(const AtomicString, closedValue, ("closed", AtomicString::ConstructFromLiteral));

- DEFINE_STATIC_LOCAL(const AtomicString, terminatedValue, ("terminated", AtomicString::ConstructFromLiteral));

+ DEFINE_STATIC_LOCAL(const AtomicString, connectedValue, ("connected"));

+ DEFINE_STATIC_LOCAL(const AtomicString, closedValue, ("closed"));

+ DEFINE_STATIC_LOCAL(const AtomicString, terminatedValue, ("terminated"));

switch (state) {

case WebPresentationConnectionState::Connected:

@@ -64,9 +64,9 @@ const AtomicString& connectionStateToString(WebPresentationConnectionState state

const AtomicString& connectionCloseReasonToString(WebPresentationConnectionCloseReason reason)

{

- DEFINE_STATIC_LOCAL(const AtomicString, errorValue, ("error", AtomicString::ConstructFromLiteral));

- DEFINE_STATIC_LOCAL(const AtomicString, closedValue, ("closed", AtomicString::ConstructFromLiteral));

- DEFINE_STATIC_LOCAL(const AtomicString, wentAwayValue, ("wentaway", AtomicString::ConstructFromLiteral));

+ DEFINE_STATIC_LOCAL(const AtomicString, errorValue, ("error"));

+ DEFINE_STATIC_LOCAL(const AtomicString, closedValue, ("closed"));

+ DEFINE_STATIC_LOCAL(const AtomicString, wentAwayValue, ("wentaway"));

switch (reason) {

case WebPresentationConnectionCloseReason::Error: