third_party/WebKit/Source/core/html/shadow/DateTimeFieldElement.cpp - Issue 1844223002: Literal AtomicString construction can rely on strlen optimization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/shadow/DateTimeFieldElement.cpp

Issue 1844223002: Literal AtomicString construction can rely on strlen optimization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/shadow/DateTimeEditElement.cpp ('k') | third_party/WebKit/Source/core/html/shadow/DateTimeFieldElements.cpp » ('j') | third_party/WebKit/Source/wtf/text/AtomicString.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/shadow/DateTimeFieldElement.cpp

diff --git a/third_party/WebKit/Source/core/html/shadow/DateTimeFieldElement.cpp b/third_party/WebKit/Source/core/html/shadow/DateTimeFieldElement.cpp

index 4b068a7abc41456c25650752e1da37e4a9b55741..163f92eb4fb4440b8bc2da128c3a7167cb3760dd 100644

--- a/third_party/WebKit/Source/core/html/shadow/DateTimeFieldElement.cpp

+++ b/third_party/WebKit/Source/core/html/shadow/DateTimeFieldElement.cpp

@@ -159,7 +159,7 @@ void DateTimeFieldElement::focusOnNextField()

void DateTimeFieldElement::initialize(const AtomicString& pseudo, const String& axHelpText, int axMinimum, int axMaximum)

{

// On accessibility, DateTimeFieldElement acts like spin button.

- setAttribute(roleAttr, AtomicString("spinbutton", AtomicString::ConstructFromLiteral));

+ setAttribute(roleAttr, AtomicString("spinbutton"));

setAttribute(aria_valuetextAttr, AtomicString(emptyValueAXText()));

setAttribute(aria_valueminAttr, AtomicString::number(axMinimum));

setAttribute(aria_valuemaxAttr, AtomicString::number(axMaximum));