third_party/WebKit/Source/core/html/forms/RangeInputType.cpp - Issue 1844223002: Literal AtomicString construction can rely on strlen optimization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/forms/RangeInputType.cpp

Issue 1844223002: Literal AtomicString construction can rely on strlen optimization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/forms/InputType.cpp ('k') | third_party/WebKit/Source/core/html/forms/SearchInputType.cpp » ('j') | third_party/WebKit/Source/wtf/text/AtomicString.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/forms/RangeInputType.cpp

diff --git a/third_party/WebKit/Source/core/html/forms/RangeInputType.cpp b/third_party/WebKit/Source/core/html/forms/RangeInputType.cpp

index f382bb1ec9960580fa8c72d227d367e5d55f545c..e73d6e7eb31f6c0d0ec8cf495750772ba26d2cee 100644

--- a/third_party/WebKit/Source/core/html/forms/RangeInputType.cpp

+++ b/third_party/WebKit/Source/core/html/forms/RangeInputType.cpp

@@ -242,7 +242,7 @@ void RangeInputType::createShadowSubtree()

Document& document = element().document();

RefPtrWillBeRawPtr<HTMLDivElement> track = HTMLDivElement::create(document);

- track->setShadowPseudoId(AtomicString("-webkit-slider-runnable-track", AtomicString::ConstructFromLiteral));

+ track->setShadowPseudoId(AtomicString("-webkit-slider-runnable-track"));

track->setAttribute(idAttr, ShadowElementNames::sliderTrack());

track->appendChild(SliderThumbElement::create(document));

RefPtrWillBeRawPtr<HTMLElement> container = SliderContainerElement::create(document);