third_party/WebKit/Source/core/html/forms/ColorInputType.cpp - Issue 1844223002: Literal AtomicString construction can rely on strlen optimization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/forms/ColorInputType.cpp

Issue 1844223002: Literal AtomicString construction can rely on strlen optimization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp ('k') | third_party/WebKit/Source/core/html/forms/FileInputType.cpp » ('j') | third_party/WebKit/Source/wtf/text/AtomicString.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/forms/ColorInputType.cpp

diff --git a/third_party/WebKit/Source/core/html/forms/ColorInputType.cpp b/third_party/WebKit/Source/core/html/forms/ColorInputType.cpp

index 3485263e72a48fb067952064a60340f9e3e5f9c1..9017634049d6c063c6b1852afcbb0cefea45508f 100644

--- a/third_party/WebKit/Source/core/html/forms/ColorInputType.cpp

+++ b/third_party/WebKit/Source/core/html/forms/ColorInputType.cpp

@@ -134,9 +134,9 @@ void ColorInputType::createShadowSubtree()

Document& document = element().document();

RefPtrWillBeRawPtr<HTMLDivElement> wrapperElement = HTMLDivElement::create(document);

- wrapperElement->setShadowPseudoId(AtomicString("-webkit-color-swatch-wrapper", AtomicString::ConstructFromLiteral));

+ wrapperElement->setShadowPseudoId(AtomicString("-webkit-color-swatch-wrapper"));

RefPtrWillBeRawPtr<HTMLDivElement> colorSwatch = HTMLDivElement::create(document);

- colorSwatch->setShadowPseudoId(AtomicString("-webkit-color-swatch", AtomicString::ConstructFromLiteral));

+ colorSwatch->setShadowPseudoId(AtomicString("-webkit-color-swatch"));

wrapperElement->appendChild(colorSwatch.release());

element().userAgentShadowRoot()->appendChild(wrapperElement.release());