third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp - Issue 1844223002: Literal AtomicString construction can rely on strlen optimization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp

Issue 1844223002: Literal AtomicString construction can rely on strlen optimization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp ('k') | third_party/WebKit/Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.cpp » ('j') | third_party/WebKit/Source/wtf/text/AtomicString.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp b/third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp

index e06a4443358e3f0116c7443633c016991af96fd6..470ffe8e0bbde9d54dd977bf958131ca2e9cfa63 100644

--- a/third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp

@@ -456,9 +456,9 @@ int HTMLTextFormControlElement::computeSelectionEnd() const

static const AtomicString& directionString(TextFieldSelectionDirection direction)

{

- DEFINE_STATIC_LOCAL(const AtomicString, none, ("none", AtomicString::ConstructFromLiteral));

- DEFINE_STATIC_LOCAL(const AtomicString, forward, ("forward", AtomicString::ConstructFromLiteral));

- DEFINE_STATIC_LOCAL(const AtomicString, backward, ("backward", AtomicString::ConstructFromLiteral));

+ DEFINE_STATIC_LOCAL(const AtomicString, none, ("none"));

+ DEFINE_STATIC_LOCAL(const AtomicString, forward, ("forward"));

+ DEFINE_STATIC_LOCAL(const AtomicString, backward, ("backward"));

switch (direction) {

case SelectionHasNoDirection:

@@ -548,11 +548,11 @@ PassRefPtrWillBeRawPtr<Range> HTMLTextFormControlElement::selection() const

const AtomicString& HTMLTextFormControlElement::autocapitalize() const

{

- DEFINE_STATIC_LOCAL(const AtomicString, off, ("off", AtomicString::ConstructFromLiteral));

- DEFINE_STATIC_LOCAL(const AtomicString, none, ("none", AtomicString::ConstructFromLiteral));

- DEFINE_STATIC_LOCAL(const AtomicString, characters, ("characters", AtomicString::ConstructFromLiteral));

- DEFINE_STATIC_LOCAL(const AtomicString, words, ("words", AtomicString::ConstructFromLiteral));

- DEFINE_STATIC_LOCAL(const AtomicString, sentences, ("sentences", AtomicString::ConstructFromLiteral));

+ DEFINE_STATIC_LOCAL(const AtomicString, off, ("off"));

+ DEFINE_STATIC_LOCAL(const AtomicString, none, ("none"));

+ DEFINE_STATIC_LOCAL(const AtomicString, characters, ("characters"));

+ DEFINE_STATIC_LOCAL(const AtomicString, words, ("words"));

+ DEFINE_STATIC_LOCAL(const AtomicString, sentences, ("sentences"));

const AtomicString& value = fastGetAttribute(autocapitalizeAttr);

if (equalIgnoringCase(value, none) || equalIgnoringCase(value, off))