third_party/WebKit/Source/core/html/HTMLProgressElement.cpp - Issue 1844223002: Literal AtomicString construction can rely on strlen optimization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLProgressElement.cpp

Issue 1844223002: Literal AtomicString construction can rely on strlen optimization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLOutputElement.cpp ('k') | third_party/WebKit/Source/core/html/HTMLSelectElement.cpp » ('j') | third_party/WebKit/Source/wtf/text/AtomicString.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLProgressElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLProgressElement.cpp b/third_party/WebKit/Source/core/html/HTMLProgressElement.cpp

index ece5134b1fcdbbeaeedb3e101af57475f6ab9b5a..dc0b4c9d34d0d5040907316db6e12293b7cba3e8 100644

--- a/third_party/WebKit/Source/core/html/HTMLProgressElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLProgressElement.cpp

@@ -150,14 +150,14 @@ void HTMLProgressElement::didAddUserAgentShadowRoot(ShadowRoot& root)

ASSERT(!m_value);

RefPtrWillBeRawPtr<ProgressInnerElement> inner = ProgressInnerElement::create(document());

- inner->setShadowPseudoId(AtomicString("-webkit-progress-inner-element", AtomicString::ConstructFromLiteral));

+ inner->setShadowPseudoId(AtomicString("-webkit-progress-inner-element"));

root.appendChild(inner);

RefPtrWillBeRawPtr<ProgressBarElement> bar = ProgressBarElement::create(document());

- bar->setShadowPseudoId(AtomicString("-webkit-progress-bar", AtomicString::ConstructFromLiteral));

+ bar->setShadowPseudoId(AtomicString("-webkit-progress-bar"));

RefPtrWillBeRawPtr<ProgressValueElement> value = ProgressValueElement::create(document());

m_value = value.get();

- m_value->setShadowPseudoId(AtomicString("-webkit-progress-value", AtomicString::ConstructFromLiteral));

+ m_value->setShadowPseudoId(AtomicString("-webkit-progress-value"));

m_value->setWidthPercentage(HTMLProgressElement::IndeterminatePosition * 100);

bar->appendChild(m_value);