third_party/WebKit/Source/core/html/HTMLImageFallbackHelper.cpp - Issue 1844223002: Literal AtomicString construction can rely on strlen optimization.

Unified Diff: third_party/WebKit/Source/core/html/HTMLImageFallbackHelper.cpp

Issue 1844223002: Literal AtomicString construction can rely on strlen optimization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLFieldSetElement.cpp ('k') | third_party/WebKit/Source/core/html/HTMLKeygenElement.cpp » ('j') | third_party/WebKit/Source/wtf/text/AtomicString.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLImageFallbackHelper.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLImageFallbackHelper.cpp b/third_party/WebKit/Source/core/html/HTMLImageFallbackHelper.cpp

index 8994abc89d7d3e8b5f940a23debdd022b3592f41..939199505e0148ff8a848fea452ad3f102cb7cdf 100644

--- a/third_party/WebKit/Source/core/html/HTMLImageFallbackHelper.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLImageFallbackHelper.cpp

@@ -36,7 +36,7 @@ void HTMLImageFallbackHelper::createAltTextShadowTree(Element& element)

RefPtrWillBeRawPtr<HTMLDivElement> container = HTMLDivElement::create(element.document());

root.appendChild(container);

- container->setAttribute(idAttr, AtomicString("alttext-container", AtomicString::ConstructFromLiteral));

+ container->setAttribute(idAttr, AtomicString("alttext-container"));

container->setInlineStyleProperty(CSSPropertyOverflow, CSSValueHidden);

container->setInlineStyleProperty(CSSPropertyBorderWidth, 1, CSSPrimitiveValue::UnitType::Pixels);

container->setInlineStyleProperty(CSSPropertyBorderStyle, CSSValueSolid);

@@ -48,15 +48,15 @@ void HTMLImageFallbackHelper::createAltTextShadowTree(Element& element)

RefPtrWillBeRawPtr<HTMLImageElement> brokenImage = HTMLImageElement::create(element.document());

container->appendChild(brokenImage);

brokenImage->setIsFallbackImage();

- brokenImage->setAttribute(idAttr, AtomicString("alttext-image", AtomicString::ConstructFromLiteral));

- brokenImage->setAttribute(widthAttr, AtomicString("16", AtomicString::ConstructFromLiteral));

- brokenImage->setAttribute(heightAttr, AtomicString("16", AtomicString::ConstructFromLiteral));

- brokenImage->setAttribute(alignAttr, AtomicString("left", AtomicString::ConstructFromLiteral));

+ brokenImage->setAttribute(idAttr, AtomicString("alttext-image"));

+ brokenImage->setAttribute(widthAttr, AtomicString("16"));

+ brokenImage->setAttribute(heightAttr, AtomicString("16"));

+ brokenImage->setAttribute(alignAttr, AtomicString("left"));

brokenImage->setInlineStyleProperty(CSSPropertyMargin, 0, CSSPrimitiveValue::UnitType::Pixels);

RefPtrWillBeRawPtr<HTMLDivElement> altText = HTMLDivElement::create(element.document());

container->appendChild(altText);

- altText->setAttribute(idAttr, AtomicString("alttext", AtomicString::ConstructFromLiteral));

+ altText->setAttribute(idAttr, AtomicString("alttext"));

altText->setInlineStyleProperty(CSSPropertyOverflow, CSSValueHidden);

altText->setInlineStyleProperty(CSSPropertyDisplay, CSSValueBlock);