third_party/WebKit/Source/core/fetch/ScriptResource.cpp - Issue 1844223002: Literal AtomicString construction can rely on strlen optimization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/ScriptResource.cpp

Issue 1844223002: Literal AtomicString construction can rely on strlen optimization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/fetch/ImageResource.cpp ('k') | third_party/WebKit/Source/core/fetch/XSLStyleSheetResource.cpp » ('j') | third_party/WebKit/Source/wtf/text/AtomicString.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/fetch/ScriptResource.cpp

diff --git a/third_party/WebKit/Source/core/fetch/ScriptResource.cpp b/third_party/WebKit/Source/core/fetch/ScriptResource.cpp

index 261454f9022b278543cbb2f3fd08a72ca85256bb..937a9d5c7a43f23ef587c5e6d72d0417556663c9 100644

--- a/third_party/WebKit/Source/core/fetch/ScriptResource.cpp

+++ b/third_party/WebKit/Source/core/fetch/ScriptResource.cpp

@@ -50,7 +50,7 @@ ScriptResource::ScriptResource(const ResourceRequest& resourceRequest, const Res

: TextResource(resourceRequest, Script, options, "application/javascript", charset)

, m_integrityDisposition(ScriptIntegrityDisposition::NotChecked)

{

- DEFINE_STATIC_LOCAL(const AtomicString, acceptScript, ("*/*", AtomicString::ConstructFromLiteral));

+ DEFINE_STATIC_LOCAL(const AtomicString, acceptScript, ("*/*"));

// It's javascript we want.

// But some websites think their scripts are <some wrong mimetype here>