third_party/WebKit/Source/build/scripts/make_css_property_names.py - Issue 1844223002: Literal AtomicString construction can rely on strlen optimization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/build/scripts/make_css_property_names.py

Issue 1844223002: Literal AtomicString construction can rely on strlen optimization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/build/scripts/templates/MakeQualifiedNames.cpp.tmpl » ('j') | third_party/WebKit/Source/wtf/text/AtomicString.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/build/scripts/make_css_property_names.py

diff --git a/third_party/WebKit/Source/build/scripts/make_css_property_names.py b/third_party/WebKit/Source/build/scripts/make_css_property_names.py

index 0d5235bb81cdfb756871d476b485e4ec6365e1b7..e4b72bc6bea6c3ad612a73d05d7dace4fe8952a1 100755

--- a/third_party/WebKit/Source/build/scripts/make_css_property_names.py

+++ b/third_party/WebKit/Source/build/scripts/make_css_property_names.py

@@ -139,10 +139,8 @@ const AtomicString& getPropertyNameAtomicString(CSSPropertyID id)

int index = id - firstCSSProperty;

static AtomicString* propertyStrings = new AtomicString[lastUnresolvedCSSProperty]; // Intentionally never destroyed.

AtomicString& propertyString = propertyStrings[index];

- if (propertyString.isNull()) {

- const char* propertyName = propertyNameStringsPool + propertyNameStringsOffsets[index];

- propertyString = AtomicString(propertyName, strlen(propertyName), AtomicString::ConstructFromLiteral);

- }

+ if (propertyString.isNull())

+ propertyString = AtomicString(propertyNameStringsPool + propertyNameStringsOffsets[index]);

return propertyString;

}