Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Side by Side Diff: third_party/WebKit/Source/wtf/text/StringStatics.cpp

Issue 1844223002: Literal AtomicString construction can rely on strlen optimization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2010 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
83 unsigned length = charactersCount - 1; 83 unsigned length = charactersCount - 1;
84 unsigned hash = StringHasher::computeHashAndMaskTop8Bits(reinterpret_cast<co nst LChar*>(characters), length); 84 unsigned hash = StringHasher::computeHashAndMaskTop8Bits(reinterpret_cast<co nst LChar*>(characters), length);
85 return adoptRef(StringImpl::createStatic(characters, length, hash)); 85 return adoptRef(StringImpl::createStatic(characters, length, hash));
86 } 86 }
87 87
88 void StringStatics::init() 88 void StringStatics::init()
89 { 89 {
90 ASSERT(isMainThread()); 90 ASSERT(isMainThread());
91 91
92 // FIXME: These should be allocated at compile time. 92 // FIXME: These should be allocated at compile time.
93 new (NotNull, (void*)&starAtom) AtomicString("*", AtomicString::ConstructFro mLiteral); 93 new (NotNull, (void*)&starAtom) AtomicString("*");
94 new (NotNull, (void*)&xmlAtom) AtomicString(addStaticASCIILiteral("xml")); 94 new (NotNull, (void*)&xmlAtom) AtomicString(addStaticASCIILiteral("xml"));
95 new (NotNull, (void*)&xmlnsAtom) AtomicString(addStaticASCIILiteral("xmlns") ); 95 new (NotNull, (void*)&xmlnsAtom) AtomicString(addStaticASCIILiteral("xmlns") );
96 new (NotNull, (void*)&xlinkAtom) AtomicString(addStaticASCIILiteral("xlink") ); 96 new (NotNull, (void*)&xlinkAtom) AtomicString(addStaticASCIILiteral("xlink") );
97 new (NotNull, (void*)&xmlnsWithColon) String("xmlns:"); 97 new (NotNull, (void*)&xmlnsWithColon) String("xmlns:");
98 } 98 }
99 99
100 } // namespace WTF 100 } // namespace WTF
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698