Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Side by Side Diff: third_party/WebKit/Source/core/html/track/AudioTrack.cpp

Issue 1844223002: Literal AtomicString construction can rely on strlen optimization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/html/track/AudioTrack.h" 5 #include "core/html/track/AudioTrack.h"
6 6
7 #include "core/html/HTMLMediaElement.h" 7 #include "core/html/HTMLMediaElement.h"
8 8
9 namespace blink { 9 namespace blink {
10 10
(...skipping 19 matching lines...) Expand all
30 return; 30 return;
31 31
32 m_enabled = enabled; 32 m_enabled = enabled;
33 33
34 if (mediaElement()) 34 if (mediaElement())
35 mediaElement()->audioTrackChanged(); 35 mediaElement()->audioTrackChanged();
36 } 36 }
37 37
38 const AtomicString& AudioTrack::alternativeKeyword() 38 const AtomicString& AudioTrack::alternativeKeyword()
39 { 39 {
40 DEFINE_STATIC_LOCAL(const AtomicString, keyword, ("alternative", AtomicStrin g::ConstructFromLiteral)); 40 DEFINE_STATIC_LOCAL(const AtomicString, keyword, ("alternative"));
41 return keyword; 41 return keyword;
42 } 42 }
43 43
44 const AtomicString& AudioTrack::descriptionsKeyword() 44 const AtomicString& AudioTrack::descriptionsKeyword()
45 { 45 {
46 DEFINE_STATIC_LOCAL(const AtomicString, keyword, ("descriptions", AtomicStri ng::ConstructFromLiteral)); 46 DEFINE_STATIC_LOCAL(const AtomicString, keyword, ("descriptions"));
47 return keyword; 47 return keyword;
48 } 48 }
49 49
50 const AtomicString& AudioTrack::mainKeyword() 50 const AtomicString& AudioTrack::mainKeyword()
51 { 51 {
52 DEFINE_STATIC_LOCAL(const AtomicString, keyword, ("main", AtomicString::Cons tructFromLiteral)); 52 DEFINE_STATIC_LOCAL(const AtomicString, keyword, ("main"));
53 return keyword; 53 return keyword;
54 } 54 }
55 55
56 const AtomicString& AudioTrack::mainDescriptionsKeyword() 56 const AtomicString& AudioTrack::mainDescriptionsKeyword()
57 { 57 {
58 DEFINE_STATIC_LOCAL(const AtomicString, keyword, ("main-desc", AtomicString: :ConstructFromLiteral)); 58 DEFINE_STATIC_LOCAL(const AtomicString, keyword, ("main-desc"));
59 return keyword; 59 return keyword;
60 } 60 }
61 61
62 const AtomicString& AudioTrack::translationKeyword() 62 const AtomicString& AudioTrack::translationKeyword()
63 { 63 {
64 DEFINE_STATIC_LOCAL(const AtomicString, keyword, ("translation", AtomicStrin g::ConstructFromLiteral)); 64 DEFINE_STATIC_LOCAL(const AtomicString, keyword, ("translation"));
65 return keyword; 65 return keyword;
66 } 66 }
67 67
68 const AtomicString& AudioTrack::commentaryKeyword() 68 const AtomicString& AudioTrack::commentaryKeyword()
69 { 69 {
70 DEFINE_STATIC_LOCAL(const AtomicString, keyword, ("commentary", AtomicString ::ConstructFromLiteral)); 70 DEFINE_STATIC_LOCAL(const AtomicString, keyword, ("commentary"));
71 return keyword; 71 return keyword;
72 } 72 }
73 73
74 bool AudioTrack::isValidKindKeyword(const String& kind) 74 bool AudioTrack::isValidKindKeyword(const String& kind)
75 { 75 {
76 return (kind == alternativeKeyword()) 76 return (kind == alternativeKeyword())
77 || (kind == descriptionsKeyword()) 77 || (kind == descriptionsKeyword())
78 || (kind == mainKeyword()) 78 || (kind == mainKeyword())
79 || (kind == mainDescriptionsKeyword()) 79 || (kind == mainDescriptionsKeyword())
80 || (kind == translationKeyword()) 80 || (kind == translationKeyword())
81 || (kind == commentaryKeyword()) 81 || (kind == commentaryKeyword())
82 || (kind == emptyAtom); 82 || (kind == emptyAtom);
83 } 83 }
84 84
85 AtomicString AudioTrack::defaultKind() const 85 AtomicString AudioTrack::defaultKind() const
86 { 86 {
87 return emptyAtom; 87 return emptyAtom;
88 } 88 }
89 89
90 } // namespace blink 90 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698