Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Side by Side Diff: third_party/WebKit/Source/core/html/shadow/SpinButtonElement.cpp

Issue 1844223002: Literal AtomicString construction can rely on strlen optimization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2008, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2008, 2010 Apple Inc. All rights reserved.
3 * Copyright (C) 2010 Google Inc. All rights reserved. 3 * Copyright (C) 2010 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 , m_capturing(false) 47 , m_capturing(false)
48 , m_upDownState(Indeterminate) 48 , m_upDownState(Indeterminate)
49 , m_pressStartingState(Indeterminate) 49 , m_pressStartingState(Indeterminate)
50 , m_repeatingTimer(this, &SpinButtonElement::repeatingTimerFired) 50 , m_repeatingTimer(this, &SpinButtonElement::repeatingTimerFired)
51 { 51 {
52 } 52 }
53 53
54 PassRefPtrWillBeRawPtr<SpinButtonElement> SpinButtonElement::create(Document& do cument, SpinButtonOwner& spinButtonOwner) 54 PassRefPtrWillBeRawPtr<SpinButtonElement> SpinButtonElement::create(Document& do cument, SpinButtonOwner& spinButtonOwner)
55 { 55 {
56 RefPtrWillBeRawPtr<SpinButtonElement> element = adoptRefWillBeNoop(new SpinB uttonElement(document, spinButtonOwner)); 56 RefPtrWillBeRawPtr<SpinButtonElement> element = adoptRefWillBeNoop(new SpinB uttonElement(document, spinButtonOwner));
57 element->setShadowPseudoId(AtomicString("-webkit-inner-spin-button", AtomicS tring::ConstructFromLiteral)); 57 element->setShadowPseudoId(AtomicString("-webkit-inner-spin-button"));
58 element->setAttribute(idAttr, ShadowElementNames::spinButton()); 58 element->setAttribute(idAttr, ShadowElementNames::spinButton());
59 return element.release(); 59 return element.release();
60 } 60 }
61 61
62 void SpinButtonElement::detach(const AttachContext& context) 62 void SpinButtonElement::detach(const AttachContext& context)
63 { 63 {
64 releaseCapture(EventDispatchDisallowed); 64 releaseCapture(EventDispatchDisallowed);
65 HTMLDivElement::detach(context); 65 HTMLDivElement::detach(context);
66 } 66 }
67 67
(...skipping 188 matching lines...) Expand 10 before | Expand all | Expand 10 after
256 return !m_spinButtonOwner || m_spinButtonOwner->shouldSpinButtonRespondToMou seEvents(); 256 return !m_spinButtonOwner || m_spinButtonOwner->shouldSpinButtonRespondToMou seEvents();
257 } 257 }
258 258
259 DEFINE_TRACE(SpinButtonElement) 259 DEFINE_TRACE(SpinButtonElement)
260 { 260 {
261 visitor->trace(m_spinButtonOwner); 261 visitor->trace(m_spinButtonOwner);
262 HTMLDivElement::trace(visitor); 262 HTMLDivElement::trace(visitor);
263 } 263 }
264 264
265 } // namespace blink 265 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698