third_party/WebKit/Source/core/html/shadow/DetailsMarkerControl.h - Issue 1844223002: Literal AtomicString construction can rely on strlen optimization.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/html/shadow/DetailsMarkerControl.h

Issue 1844223002: Literal AtomicString construction can rely on strlen optimization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/shadow/DateTimeFieldElements.cpp ('k') | third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp » ('j') | third_party/WebKit/Source/wtf/text/AtomicString.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2011 Google Inc. All rights reserved.	2 * Copyright (C) 2011 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 35 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
46 private:	46 private:

47 LayoutObject* createLayoutObject(const ComputedStyle&) override;	47 LayoutObject* createLayoutObject(const ComputedStyle&) override;

48 bool layoutObjectIsNeeded(const ComputedStyle&) override;	48 bool layoutObjectIsNeeded(const ComputedStyle&) override;

49	49

50 HTMLSummaryElement* summaryElement();	50 HTMLSummaryElement* summaryElement();

51 };	51 };

52	52

53 inline PassRefPtrWillBeRawPtr<DetailsMarkerControl> DetailsMarkerControl::create (Document& document)	53 inline PassRefPtrWillBeRawPtr<DetailsMarkerControl> DetailsMarkerControl::create (Document& document)

54 {	54 {

55 RefPtrWillBeRawPtr<DetailsMarkerControl> element = adoptRefWillBeNoop(new De tailsMarkerControl(document));	55 RefPtrWillBeRawPtr<DetailsMarkerControl> element = adoptRefWillBeNoop(new De tailsMarkerControl(document));

56 element->setShadowPseudoId(AtomicString("-webkit-details-marker", AtomicStri ng::ConstructFromLiteral));	56 element->setShadowPseudoId(AtomicString("-webkit-details-marker"));

57 return element.release();	57 return element.release();

58 }	58 }

59	59

60 } // namespace blink	60 } // namespace blink

61	61

62 #endif	62 #endif

OLD	NEW