Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: third_party/WebKit/Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.cpp

Issue 1844223002: Literal AtomicString construction can rely on strlen optimization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 if (!element().document().isActive()) 70 if (!element().document().isActive())
71 return; 71 return;
72 DateTimeChooserParameters parameters; 72 DateTimeChooserParameters parameters;
73 if (!element().setupDateTimeChooserParameters(parameters)) 73 if (!element().setupDateTimeChooserParameters(parameters))
74 return; 74 return;
75 m_dateTimeChooser = element().document().frameHost()->chromeClient().openDat eTimeChooser(this, parameters); 75 m_dateTimeChooser = element().document().frameHost()->chromeClient().openDat eTimeChooser(this, parameters);
76 } 76 }
77 77
78 void BaseChooserOnlyDateAndTimeInputType::createShadowSubtree() 78 void BaseChooserOnlyDateAndTimeInputType::createShadowSubtree()
79 { 79 {
80 DEFINE_STATIC_LOCAL(AtomicString, valueContainerPseudo, ("-webkit-date-and-t ime-value", AtomicString::ConstructFromLiteral)); 80 DEFINE_STATIC_LOCAL(AtomicString, valueContainerPseudo, ("-webkit-date-and-t ime-value"));
81 81
82 RefPtrWillBeRawPtr<HTMLDivElement> valueContainer = HTMLDivElement::create(e lement().document()); 82 RefPtrWillBeRawPtr<HTMLDivElement> valueContainer = HTMLDivElement::create(e lement().document());
83 valueContainer->setShadowPseudoId(valueContainerPseudo); 83 valueContainer->setShadowPseudoId(valueContainerPseudo);
84 element().userAgentShadowRoot()->appendChild(valueContainer.get()); 84 element().userAgentShadowRoot()->appendChild(valueContainer.get());
85 updateView(); 85 updateView();
86 } 86 }
87 87
88 void BaseChooserOnlyDateAndTimeInputType::updateView() 88 void BaseChooserOnlyDateAndTimeInputType::updateView()
89 { 89 {
90 Node* node = element().userAgentShadowRoot()->firstChild(); 90 Node* node = element().userAgentShadowRoot()->firstChild();
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
160 } 160 }
161 161
162 void BaseChooserOnlyDateAndTimeInputType::accessKeyAction(bool sendMouseEvents) 162 void BaseChooserOnlyDateAndTimeInputType::accessKeyAction(bool sendMouseEvents)
163 { 163 {
164 BaseDateAndTimeInputType::accessKeyAction(sendMouseEvents); 164 BaseDateAndTimeInputType::accessKeyAction(sendMouseEvents);
165 BaseClickableWithKeyInputType::accessKeyAction(element(), sendMouseEvents); 165 BaseClickableWithKeyInputType::accessKeyAction(element(), sendMouseEvents);
166 } 166 }
167 167
168 } 168 }
169 #endif 169 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698