third_party/WebKit/Source/core/html/HTMLAudioElement.cpp - Issue 1844223002: Literal AtomicString construction can rely on strlen optimization.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLAudioElement.cpp

Issue 1844223002: Literal AtomicString construction can rely on strlen optimization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/core/fetch/XSLStyleSheetResource.cpp ('k') | third_party/WebKit/Source/core/html/HTMLButtonElement.cpp » ('j') | third_party/WebKit/Source/wtf/text/AtomicString.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2007, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.	2 * Copyright (C) 2007, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 * 1. Redistributions of source code must retain the above copyright	7 * 1. Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * 2. Redistributions in binary form must reproduce the above copyright	9 * 2. Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 31 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
42 RefPtrWillBeRawPtr<HTMLAudioElement> audio = adoptRefWillBeNoop(new HTMLAudi oElement(document));	42 RefPtrWillBeRawPtr<HTMLAudioElement> audio = adoptRefWillBeNoop(new HTMLAudi oElement(document));

43 audio->ensureUserAgentShadowRoot();	43 audio->ensureUserAgentShadowRoot();

44 audio->suspendIfNeeded();	44 audio->suspendIfNeeded();

45 return audio.release();	45 return audio.release();

46 }	46 }

47	47

48 PassRefPtrWillBeRawPtr<HTMLAudioElement> HTMLAudioElement::createForJSConstructo r(Document& document, const AtomicString& src)	48 PassRefPtrWillBeRawPtr<HTMLAudioElement> HTMLAudioElement::createForJSConstructo r(Document& document, const AtomicString& src)

49 {	49 {

50 RefPtrWillBeRawPtr<HTMLAudioElement> audio = adoptRefWillBeNoop(new HTMLAudi oElement(document));	50 RefPtrWillBeRawPtr<HTMLAudioElement> audio = adoptRefWillBeNoop(new HTMLAudi oElement(document));

51 audio->ensureUserAgentShadowRoot();	51 audio->ensureUserAgentShadowRoot();

52 audio->setPreload(AtomicString("auto", AtomicString::ConstructFromLiteral));	52 audio->setPreload(AtomicString("auto"));

53 if (!src.isNull())	53 if (!src.isNull())

54 audio->setSrc(src);	54 audio->setSrc(src);

55 audio->suspendIfNeeded();	55 audio->suspendIfNeeded();

56 return audio.release();	56 return audio.release();

57 }	57 }

58	58

59 } // namespace blink	59 } // namespace blink

OLD	NEW