Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Side by Side Diff: third_party/WebKit/Source/core/fetch/XSLStyleSheetResource.cpp

Issue 1844223002: Literal AtomicString construction can rely on strlen optimization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de) 2 Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de)
3 Copyright (C) 2001 Dirk Mueller (mueller@kde.org) 3 Copyright (C) 2001 Dirk Mueller (mueller@kde.org)
4 Copyright (C) 2002 Waldo Bastian (bastian@kde.org) 4 Copyright (C) 2002 Waldo Bastian (bastian@kde.org)
5 Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com) 5 Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)
6 Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 7
8 This library is free software; you can redistribute it and/or 8 This library is free software; you can redistribute it and/or
9 modify it under the terms of the GNU Library General Public 9 modify it under the terms of the GNU Library General Public
10 License as published by the Free Software Foundation; either 10 License as published by the Free Software Foundation; either
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 { 52 {
53 ASSERT(RuntimeEnabledFeatures::xsltEnabled()); 53 ASSERT(RuntimeEnabledFeatures::xsltEnabled());
54 request.mutableResourceRequest().setRequestContext(WebURLRequest::RequestCon textXSLT); 54 request.mutableResourceRequest().setRequestContext(WebURLRequest::RequestCon textXSLT);
55 return toXSLStyleSheetResource(fetcher->requestResource(request, XSLStyleShe etResourceFactory())); 55 return toXSLStyleSheetResource(fetcher->requestResource(request, XSLStyleShe etResourceFactory()));
56 } 56 }
57 57
58 XSLStyleSheetResource::XSLStyleSheetResource(const ResourceRequest& resourceRequ est, const ResourceLoaderOptions& options, const String& charset) 58 XSLStyleSheetResource::XSLStyleSheetResource(const ResourceRequest& resourceRequ est, const ResourceLoaderOptions& options, const String& charset)
59 : StyleSheetResource(resourceRequest, XSLStyleSheet, options, "text/xsl", ch arset) 59 : StyleSheetResource(resourceRequest, XSLStyleSheet, options, "text/xsl", ch arset)
60 { 60 {
61 ASSERT(RuntimeEnabledFeatures::xsltEnabled()); 61 ASSERT(RuntimeEnabledFeatures::xsltEnabled());
62 DEFINE_STATIC_LOCAL(const AtomicString, acceptXSLT, ("text/xml, application/ xml, application/xhtml+xml, text/xsl, application/rss+xml, application/atom+xml" , AtomicString::ConstructFromLiteral)); 62 DEFINE_STATIC_LOCAL(const AtomicString, acceptXSLT, ("text/xml, application/ xml, application/xhtml+xml, text/xsl, application/rss+xml, application/atom+xml" ));
63 63
64 // It's XML we want. 64 // It's XML we want.
65 // FIXME: This should accept more general xml formats */*+xml, image/svg+xml for example. 65 // FIXME: This should accept more general xml formats */*+xml, image/svg+xml for example.
66 setAccept(acceptXSLT); 66 setAccept(acceptXSLT);
67 } 67 }
68 68
69 void XSLStyleSheetResource::didAddClient(ResourceClient* c) 69 void XSLStyleSheetResource::didAddClient(ResourceClient* c)
70 { 70 {
71 ASSERT(StyleSheetResourceClient::isExpectedType(c)); 71 ASSERT(StyleSheetResourceClient::isExpectedType(c));
72 Resource::didAddClient(c); 72 Resource::didAddClient(c);
73 if (!isLoading()) 73 if (!isLoading())
74 static_cast<StyleSheetResourceClient*>(c)->setXSLStyleSheet(m_resourceRe quest.url(), m_response.url(), m_sheet); 74 static_cast<StyleSheetResourceClient*>(c)->setXSLStyleSheet(m_resourceRe quest.url(), m_response.url(), m_sheet);
75 } 75 }
76 76
77 void XSLStyleSheetResource::checkNotify() 77 void XSLStyleSheetResource::checkNotify()
78 { 78 {
79 if (m_data.get()) 79 if (m_data.get())
80 m_sheet = decodedText(); 80 m_sheet = decodedText();
81 81
82 ResourceClientWalker<StyleSheetResourceClient> w(m_clients); 82 ResourceClientWalker<StyleSheetResourceClient> w(m_clients);
83 while (StyleSheetResourceClient* c = w.next()) 83 while (StyleSheetResourceClient* c = w.next())
84 c->setXSLStyleSheet(m_resourceRequest.url(), m_response.url(), m_sheet); 84 c->setXSLStyleSheet(m_resourceRequest.url(), m_response.url(), m_sheet);
85 } 85 }
86 86
87 } // namespace blink 87 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698