Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Unified Diff: service/datastore/raw_interface.go

Issue 1844183003: Don't filter "Stop" error in raw interface. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/gae@master
Patch Set: Count filter doesn't count Stop as error. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « service/datastore/datastore.go ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: service/datastore/raw_interface.go
diff --git a/service/datastore/raw_interface.go b/service/datastore/raw_interface.go
index d19c65b59573300f05cff1fbf8d6c0217dce50c7..bfb9a9f83da4af42d3427cecc000ca4cdfac4766 100644
--- a/service/datastore/raw_interface.go
+++ b/service/datastore/raw_interface.go
@@ -37,6 +37,9 @@ type RawRunCB func(key *Key, val PropertyMap, getCursor CursorCB) error
// * It may be nil if some of the keys to the GetMulti were bad, since all
// keys are validated before the RPC occurs!
// - err is an error associated with this entity (e.g. ErrNoSuchEntity).
+//
+// Return nil to continue iterating, or an error to stop. If you return the
+// error `Stop`, then GetMulti will stop the query and return nil.
type GetMultiCB func(val PropertyMap, err error) error
// PutMultiCB is the callback signature provided to RawInterface.PutMulti
@@ -45,11 +48,17 @@ type GetMultiCB func(val PropertyMap, err error) error
// * It may be nil if some of the keys/vals to the PutMulti were bad, since
// all keys are validated before the RPC occurs!
// - err is an error associated with putting this entity.
+//
+// Return nil to continue iterating, or an error to stop. If you return the
+// error `Stop`, then PutMulti will stop the query and return nil.
type PutMultiCB func(key *Key, err error) error
// DeleteMultiCB is the callback signature provided to RawInterface.DeleteMulti
//
// - err is an error associated with deleting this entity.
+//
+// Return nil to continue iterating, or an error to stop. If you return the
+// error `Stop`, then DeleteMulti will stop the query and return nil.
type DeleteMultiCB func(err error) error
type nullMetaGetterType struct{}
« no previous file with comments | « service/datastore/datastore.go ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698