Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1844113003:
Set number values of getting TRANSFORM_FEEDBACK_BUFFER_MODE (Closed)
DescriptionSet number values of getting TRANSFORM_FEEDBACK_BUFFER_MODE
BUG=598624
TEST=deqp/functional/gles3/shaderstatequery.html
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
Committed: https://crrev.com/5247589044b9e2a51cf350577dc6df459958d7f4
Cr-Commit-Position: refs/heads/master@{#385613}
Patch Set 1 #
Messages
Total messages: 17 (8 generated)
Description was changed from ========== Set number values of getting TRANSFORM_FEEDBACK_BUFFER_MODE BUG=598624 ========== to ========== Set number values of getting TRANSFORM_FEEDBACK_BUFFER_MODE BUG=598624 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel ==========
Description was changed from ========== Set number values of getting TRANSFORM_FEEDBACK_BUFFER_MODE BUG=598624 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel ========== to ========== Set number values of getting TRANSFORM_FEEDBACK_BUFFER_MODE BUG=598624 TEST=deqp/functional/gles3/shaderstatequery.html CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel ==========
qiankun.miao@intel.com changed reviewers: + bajones@chromium.org, kbr@chromium.org, yunchao.he@intel.com, zmo@chromium.org
PTAL.
Sorry for the delay reviewing this. LGTM but Mo needs to review it too.
lgtm
The CQ bit was checked by zmo@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844113003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844113003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_optional_gpu_tests_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)
On 2016/04/06 23:44:01, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > mac_optional_gpu_tests_rel on tryserver.chromium.mac (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...) That's http://crbug.com/601204 . Re-CQ'ing.
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844113003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844113003/1
Message was sent while issue was closed.
Description was changed from ========== Set number values of getting TRANSFORM_FEEDBACK_BUFFER_MODE BUG=598624 TEST=deqp/functional/gles3/shaderstatequery.html CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel ========== to ========== Set number values of getting TRANSFORM_FEEDBACK_BUFFER_MODE BUG=598624 TEST=deqp/functional/gles3/shaderstatequery.html CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Set number values of getting TRANSFORM_FEEDBACK_BUFFER_MODE BUG=598624 TEST=deqp/functional/gles3/shaderstatequery.html CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel ========== to ========== Set number values of getting TRANSFORM_FEEDBACK_BUFFER_MODE BUG=598624 TEST=deqp/functional/gles3/shaderstatequery.html CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel Committed: https://crrev.com/5247589044b9e2a51cf350577dc6df459958d7f4 Cr-Commit-Position: refs/heads/master@{#385613} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/5247589044b9e2a51cf350577dc6df459958d7f4 Cr-Commit-Position: refs/heads/master@{#385613} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
