Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 18441005: Make cctest/test-debug pass with extensions installed (Closed)

Created:
7 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 5 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Make cctest/test-debug pass with extensions installed Compiling extensions during context creation triggers debug events. Work around this by installing the event listener after creating the context BUG=v8:2745 R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15523

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -10 lines) Patch
M test/cctest/test-debug.cc View 8 chunks +11 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
7 years, 5 months ago (2013-07-05 12:24:53 UTC) #1
Yang
On 2013/07/05 12:24:53, jochen wrote: LGTM.
7 years, 5 months ago (2013-07-05 12:58:24 UTC) #2
Yang
7 years, 5 months ago (2013-07-05 13:33:24 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r15523 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698