Color parsing in CSSParser: avoid using ColorValueCache on worker thread

Color parsing in CSSParser: avoid using ColorValueCache on worker thread

ColorValueCache is one of the many heap hashmap that CSSValuePool (a global
static instance) maintains to store re-usable CSS Color values. It is not
thread-safe; thus it is problematic when new CSS Color values are inserted into
it and later retrieved from it, on worker threads.

Because making CSSParser thread-safe is not a trivial effort, this patch is a
temporary (and possibly permanent depending on discussions) solution for the
correct color parsing of OffscreenCanvas on a worker.

BUG=598706
Committed: https://crrev.com/4c51c29704df5572015f4d4b12589c9e6dca437c
Cr-Commit-Position: refs/heads/master@{#384448}

[xlai (Olivia), 2016-03-30 21:33:09]

xlai@chromium.org changed reviewers:
+ junov@google.com

[xlai (Olivia), 2016-03-30 21:33:10]

Perhaps we can include this patch into the doc as well?

[xlai (Olivia), 2016-03-30 21:33:20]

Description was changed from

==========
Color parsing in CSSParser: avoid using ColorValueCache on worker thread

ColorValueCache is one of the many heap hashmap that CSSValuePool (a global
static instance) maintains to store re-usable CSS Color values. It is not
thread-safe; thus it is problematic when new CSS Color values are inserted into
it and later retrieved from it, on worker threads.

Because making CSSParser thread-safe is not a trivial effort, this patch is a
temporary (and possibly permanent depending on discussions) solution for the
correct color parsing of OffscreenCanvas on a worker.


BUG=598706
==========

to

==========
Color parsing in CSSParser: avoid using ColorValueCache on worker thread

ColorValueCache is one of the many heap hashmap that CSSValuePool (a global
static instance) maintains to store re-usable CSS Color values. It is not
thread-safe; thus it is problematic when new CSS Color values are inserted into
it and later retrieved from it, on worker threads.

Because making CSSParser thread-safe is not a trivial effort, this patch is a
temporary (and possibly permanent depending on discussions) solution for the
correct color parsing of OffscreenCanvas on a worker.


BUG=598706
==========

[xlai (Olivia), 2016-03-30 21:33:21]

xlai@chromium.org changed reviewers:
+ junov@chromium.org
- junov@google.com

[xlai (Olivia), 2016-03-31 19:21:02]

Added layout tests for Hexademical color and RGB color specifically.

[xlai (Olivia), 2016-03-31 21:46:42]

Compressing 3 layout tests into 1. This is also an example when
OffscreenCanvas.transferToImageBitmap is called multiple times on the same
canvas.

[Justin Novosad, 2016-03-31 21:52:12]

lgtm with nit

https://codereview.chromium.org/1844083002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-fillRect-in-worker.html
(right):

https://codereview.chromium.org/1844083002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-fillRect-in-worker.html:5:
<canvas id='output2' width='100' height='100' style='background:blue'></canvas>
Just use red for all the backgrounds. Red is the universal color of failure.

[xlai (Olivia), 2016-03-31 22:07:29]

The CQ bit was checked by xlai@chromium.org

[xlai (Olivia), 2016-03-31 22:07:29]

The patchset sent to the CQ was uploaded after l-g-t-m from junov@chromium.org
Link to the patchset: https://codereview.chromium.org/1844083002/#ps60001
(title: "Nits")

[commit-bot: I haz the power, 2016-03-31 22:08:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1844083002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1844083002/60001

[commit-bot: I haz the power, 2016-03-31 22:11:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-31 22:11:27]

Try jobs failed on following builders:
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)

[xlai (Olivia), 2016-03-31 23:08:15]

The CQ bit was checked by xlai@chromium.org

[xlai (Olivia), 2016-03-31 23:08:15]

The patchset sent to the CQ was uploaded after l-g-t-m from junov@chromium.org
Link to the patchset: https://codereview.chromium.org/1844083002/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2016-03-31 23:08:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1844083002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1844083002/80001

[commit-bot: I haz the power, 2016-04-01 00:32:56]

Description was changed from

==========
Color parsing in CSSParser: avoid using ColorValueCache on worker thread

ColorValueCache is one of the many heap hashmap that CSSValuePool (a global
static instance) maintains to store re-usable CSS Color values. It is not
thread-safe; thus it is problematic when new CSS Color values are inserted into
it and later retrieved from it, on worker threads.

Because making CSSParser thread-safe is not a trivial effort, this patch is a
temporary (and possibly permanent depending on discussions) solution for the
correct color parsing of OffscreenCanvas on a worker.


BUG=598706
==========

to

==========
Color parsing in CSSParser: avoid using ColorValueCache on worker thread

ColorValueCache is one of the many heap hashmap that CSSValuePool (a global
static instance) maintains to store re-usable CSS Color values. It is not
thread-safe; thus it is problematic when new CSS Color values are inserted into
it and later retrieved from it, on worker threads.

Because making CSSParser thread-safe is not a trivial effort, this patch is a
temporary (and possibly permanent depending on discussions) solution for the
correct color parsing of OffscreenCanvas on a worker.


BUG=598706
==========

[commit-bot: I haz the power, 2016-04-01 00:32:57]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-04-01 00:34:06]

Description was changed from

==========
Color parsing in CSSParser: avoid using ColorValueCache on worker thread

ColorValueCache is one of the many heap hashmap that CSSValuePool (a global
static instance) maintains to store re-usable CSS Color values. It is not
thread-safe; thus it is problematic when new CSS Color values are inserted into
it and later retrieved from it, on worker threads.

Because making CSSParser thread-safe is not a trivial effort, this patch is a
temporary (and possibly permanent depending on discussions) solution for the
correct color parsing of OffscreenCanvas on a worker.


BUG=598706
==========

to

==========
Color parsing in CSSParser: avoid using ColorValueCache on worker thread

ColorValueCache is one of the many heap hashmap that CSSValuePool (a global
static instance) maintains to store re-usable CSS Color values. It is not
thread-safe; thus it is problematic when new CSS Color values are inserted into
it and later retrieved from it, on worker threads.

Because making CSSParser thread-safe is not a trivial effort, this patch is a
temporary (and possibly permanent depending on discussions) solution for the
correct color parsing of OffscreenCanvas on a worker.

BUG=598706

Committed: https://crrev.com/4c51c29704df5572015f4d4b12589c9e6dca437c
Cr-Commit-Position: refs/heads/master@{#384448}
==========

[commit-bot: I haz the power, 2016-04-01 00:34:07]

Patchset 5 (id:??) landed as
https://crrev.com/4c51c29704df5572015f4d4b12589c9e6dca437c
Cr-Commit-Position: refs/heads/master@{#384448}