Make StringData a templated class.

Make StringData a templated class.

First step in making the same changes to CFX_WideString that we
just made to CFX_ByteString.

Committed: https://pdfium.googlesource.com/pdfium/+/6fb598b9dff93602134f1976443ae6d6ff015c4d

[Tom Sepez, 2016-03-30 22:32:46]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-03-30 22:32:46]

Lei, for review.

[Lei Zhang, 2016-03-31 00:07:19]

Include core/fxcrt/cfx_string_data_template.h in GN/GYP build files?

https://codereview.chromium.org/1844073003/diff/1/core/fxcrt/cfx_string_data_...
File core/fxcrt/cfx_string_data_template.h (right):

https://codereview.chromium.org/1844073003/diff/1/core/fxcrt/cfx_string_data_...
core/fxcrt/cfx_string_data_template.h:11: #include
"core/fxcrt/include/fx_memory.h"
nit: alphabetical order

https://codereview.chromium.org/1844073003/diff/1/core/fxcrt/cfx_string_data_...
core/fxcrt/cfx_string_data_template.h:20: // Fixed portion of header plus a NUL
char not included in m_nAllocLength.
... is not included

https://codereview.chromium.org/1844073003/diff/1/core/fxcrt/fx_basic_bstring...
File core/fxcrt/fx_basic_bstring.cpp (right):

https://codereview.chromium.org/1844073003/diff/1/core/fxcrt/fx_basic_bstring...
core/fxcrt/fx_basic_bstring.cpp:380: char buf[32];
You only need 21 bytes right? 2^63 is 19 digits + 1 for negative sign + 1 for
NUL, and we only do base 10 and 16. There's also magic 32 / 31 constants in
Buffer_itoa().

[Tom Sepez, 2016-03-31 17:11:32]

On 2016/03/31 00:07:19, Lei Zhang wrote:
> Include core/fxcrt/cfx_string_data_template.h in GN/GYP build files?
Ooops.  Thanks.

[Tom Sepez, 2016-03-31 17:16:51]

PTAL.

https://codereview.chromium.org/1844073003/diff/1/core/fxcrt/cfx_string_data_...
File core/fxcrt/cfx_string_data_template.h (right):

https://codereview.chromium.org/1844073003/diff/1/core/fxcrt/cfx_string_data_...
core/fxcrt/cfx_string_data_template.h:11: #include
"core/fxcrt/include/fx_memory.h"
On 2016/03/31 00:07:19, Lei Zhang wrote:
> nit: alphabetical order

Done.

https://codereview.chromium.org/1844073003/diff/1/core/fxcrt/cfx_string_data_...
core/fxcrt/cfx_string_data_template.h:20: // Fixed portion of header plus a NUL
char not included in m_nAllocLength.
On 2016/03/31 00:07:18, Lei Zhang wrote:
> ... is not included

Done.

https://codereview.chromium.org/1844073003/diff/1/core/fxcrt/fx_basic_bstring...
File core/fxcrt/fx_basic_bstring.cpp (right):

https://codereview.chromium.org/1844073003/diff/1/core/fxcrt/fx_basic_bstring...
core/fxcrt/fx_basic_bstring.cpp:380: char buf[32];
On 2016/03/31 00:07:19, Lei Zhang wrote:
> You only need 21 bytes right? 2^63 is 19 digits + 1 for negative sign + 1 for
> NUL, and we only do base 10 and 16. There's also magic 32 / 31 constants in
> Buffer_itoa().

Acknowledged. Gonna leave it for now.

[Lei Zhang, 2016-03-31 18:54:41]

lgtm

[Tom Sepez, 2016-04-05 19:28:31]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2016-04-05 19:28:31]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/1844073003/#ps100001
(title: "Re-rebase")

[commit-bot: I haz the power, 2016-04-05 19:28:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1844073003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1844073003/100001

[commit-bot: I haz the power, 2016-04-05 19:40:50]

Description was changed from

==========
Make StringData a templated class.

First step in making the same changes to CFX_WideString that we
just made to CFX_ByteString.
==========

to

==========
Make StringData a templated class.

First step in making the same changes to CFX_WideString that we
just made to CFX_ByteString.

Committed:
https://pdfium.googlesource.com/pdfium/+/6fb598b9dff93602134f1976443ae6d6ff01...
==========

[commit-bot: I haz the power, 2016-04-05 19:40:51]

Committed patchset #6 (id:100001) as
https://pdfium.googlesource.com/pdfium/+/6fb598b9dff93602134f1976443ae6d6ff01...