Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1844073002: Remove "#pragma comment(lib" in device. (Closed)

Created:
4 years, 8 months ago by jam
Modified:
4 years, 8 months ago
CC:
chromium-reviews, ortuno+watch_chromium.org, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove "#pragma comment(lib" in device. BUG=597028 Committed: https://crrev.com/72b98c0c1402b3927d3b16f73052f5c4895f04da Cr-Commit-Position: refs/heads/master@{#384349}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : fix delay loading crashes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -8 lines) Patch
M device/bluetooth/BUILD.gn View 1 2 1 chunk +7 lines, -1 line 0 comments Download
M device/bluetooth/bluetooth.gyp View 1 2 2 chunks +12 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_init_win.h View 1 chunk +0 lines, -3 lines 0 comments Download
M device/hid/BUILD.gn View 1 chunk +7 lines, -0 lines 0 comments Download
M device/hid/hid.gyp View 1 1 chunk +20 lines, -0 lines 0 comments Download
M device/hid/hid_service_win.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jam
4 years, 8 months ago (2016-03-31 16:50:49 UTC) #2
Reilly Grant (use Gerrit)
lgtm
4 years, 8 months ago (2016-03-31 17:29:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844073002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844073002/40001
4 years, 8 months ago (2016-03-31 17:30:59 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-03-31 18:58:01 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 18:59:20 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/72b98c0c1402b3927d3b16f73052f5c4895f04da
Cr-Commit-Position: refs/heads/master@{#384349}

Powered by Google App Engine
This is Rietveld 408576698