Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1844053005: S390: [wasm] Fixed float-to-int conversion tests. (Closed)

Created:
4 years, 8 months ago by john.yan
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: [wasm] Fixed float-to-int conversion tests. port ac7f0e2b6183839e55136647f81d6c01ac1b93af Original Commit Message: *) For all tests the input validation was incorrect, i.e. some values were considered invalid although they were valid. The problem was that values which are outside int range can get in range through truncation. *) Removed an assertion in the x64 code generation of TruncateFloat64ToUint32 which trapped on negative inputs. *) Introduced a new TF operator TruncateFloat32ToUint32 which does the same as ChangeFloat32ToUint32 but does not trap on negative inputs. R=titzer@chromium.org, ahaas@chromium.org, joransiu@ca.ibm.com, mbrandy@us.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/652853daa643e7fb10dd36db92a2b01b960f5b91 Cr-Commit-Position: refs/heads/master@{#35207}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/compiler/s390/instruction-selector-s390.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
john.yan
PTAL
4 years, 8 months ago (2016-04-01 13:44:58 UTC) #1
JoranSiu
On 2016/04/01 13:44:58, john.yan wrote: > PTAL lgtm
4 years, 8 months ago (2016-04-01 13:45:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844053005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844053005/1
4 years, 8 months ago (2016-04-01 13:48:27 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-01 14:10:20 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 14:11:28 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/652853daa643e7fb10dd36db92a2b01b960f5b91
Cr-Commit-Position: refs/heads/master@{#35207}

Powered by Google App Engine
This is Rietveld 408576698