third_party/WebKit/Source/modules/fetch/Body.h - Issue 1844053003: CREDENTIAL: Rework the integration with Fetch (1/2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/fetch/Body.h

Issue 1844053003: CREDENTIAL: Rework the integration with Fetch (1/2) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: clear attachedcredentials Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/modules/v8/DictionaryHelperForModules.cpp ('k') | third_party/WebKit/Source/modules/fetch/Body.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/fetch/Body.h

diff --git a/third_party/WebKit/Source/modules/fetch/Body.h b/third_party/WebKit/Source/modules/fetch/Body.h

index de4c11171e5bd95c514f43d419852239703984dd..535f0f91ad99ec27ad5bd6bf137c0c6d83a76736 100644

--- a/third_party/WebKit/Source/modules/fetch/Body.h

+++ b/third_party/WebKit/Source/modules/fetch/Body.h

@@ -61,10 +61,6 @@ public:

ActiveDOMObject::trace(visitor);

}

- // https://w3c.github.io/webappsec-credential-management/#monkey-patching-fetch-2

- void setOpaque() { m_opaque = true; }

- bool opaque() const { return m_opaque; }

private:

ReadableByteStream* body();

virtual String mimeType() const = 0;

@@ -74,8 +70,6 @@ private:

// an empty ScriptPromise if the consumption may proceed, and a

// ScriptPromise rejected with a TypeError if it ought to be blocked.

ScriptPromise rejectInvalidConsumption(ScriptState*);

- bool m_opaque;

};

} // namespace blink