Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 1844043004: Achieve feature pairity with pre 2.7.4 (Closed)

Created:
4 years, 8 months ago by iannucci
Modified:
4 years, 8 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Achieve feature pairity with pre 2.7.4 XCopy the docs from depot_tools. It's pretty fast and doesn't require reinventing the world right now. CIPD will be a better long-term strategy anyway. R=dnj@google.com, dnj@chromium.org BUG=598959 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=299577

Patch Set 1 #

Patch Set 2 : actually add NUL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M bootstrap/win/win_tools.bat View 1 2 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
iannucci
4 years, 8 months ago (2016-03-31 00:58:15 UTC) #1
iannucci
+mmoss who reviewed the original patch I think.
4 years, 8 months ago (2016-03-31 01:00:31 UTC) #3
dnj (Google)
Seems reasonable.
4 years, 8 months ago (2016-03-31 01:01:19 UTC) #5
dnj (Google)
Oops lgtm
4 years, 8 months ago (2016-03-31 01:01:40 UTC) #6
iannucci
4 years, 8 months ago (2016-03-31 01:09:13 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 299577.

Powered by Google App Engine
This is Rietveld 408576698