Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Side by Side Diff: PRESUBMIT.py

Issue 1844033002: Permit MaterialDesignController to make IO call (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: presubmit change Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | ui/base/material_design/material_design_controller.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into depot_tools. 8 for more details about the presubmit API built into depot_tools.
9 """ 9 """
10 10
(...skipping 166 matching lines...) Expand 10 before | Expand all | Expand 10 after
177 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_browser_main\.cc$", 177 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_browser_main\.cc$",
178 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_message_filter\.cc$", 178 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_message_filter\.cc$",
179 r"^mojo[\\\/]edk[\\\/]embedder[\\\/]" + 179 r"^mojo[\\\/]edk[\\\/]embedder[\\\/]" +
180 r"simple_platform_shared_buffer_posix\.cc$", 180 r"simple_platform_shared_buffer_posix\.cc$",
181 r"^net[\\\/]disk_cache[\\\/]cache_util\.cc$", 181 r"^net[\\\/]disk_cache[\\\/]cache_util\.cc$",
182 r"^net[\\\/]url_request[\\\/]test_url_fetcher_factory\.cc$", 182 r"^net[\\\/]url_request[\\\/]test_url_fetcher_factory\.cc$",
183 r"^remoting[\\\/]host[\\\/]security_key[\\\/]" 183 r"^remoting[\\\/]host[\\\/]security_key[\\\/]"
184 "gnubby_auth_handler_linux\.cc$", 184 "gnubby_auth_handler_linux\.cc$",
185 r"^ui[\\\/]ozone[\\\/]platform[\\\/]drm[\\\/]host[\\\/]" 185 r"^ui[\\\/]ozone[\\\/]platform[\\\/]drm[\\\/]host[\\\/]"
186 "drm_display_host_manager\.cc$", 186 "drm_display_host_manager\.cc$",
187 r"^ui[\\\/]base[\\\/]material_design[\\\/]"
188 "material_design_controller\.cc$",
187 ), 189 ),
188 ), 190 ),
189 ( 191 (
190 'skia::RefPtr', 192 'skia::RefPtr',
191 ( 193 (
192 'The use of skia::RefPtr is prohibited. ', 194 'The use of skia::RefPtr is prohibited. ',
193 'Please use sk_sp<> instead.' 195 'Please use sk_sp<> instead.'
194 ), 196 ),
195 True, 197 True,
196 (), 198 (),
(...skipping 1926 matching lines...) Expand 10 before | Expand all | Expand 10 after
2123 results.extend(input_api.canned_checks.CheckTreeIsOpen( 2125 results.extend(input_api.canned_checks.CheckTreeIsOpen(
2124 input_api, 2126 input_api,
2125 output_api, 2127 output_api,
2126 json_url='http://chromium-status.appspot.com/current?format=json')) 2128 json_url='http://chromium-status.appspot.com/current?format=json'))
2127 2129
2128 results.extend(input_api.canned_checks.CheckChangeHasBugField( 2130 results.extend(input_api.canned_checks.CheckChangeHasBugField(
2129 input_api, output_api)) 2131 input_api, output_api))
2130 results.extend(input_api.canned_checks.CheckChangeHasDescription( 2132 results.extend(input_api.canned_checks.CheckChangeHasDescription(
2131 input_api, output_api)) 2133 input_api, output_api))
2132 return results 2134 return results
OLDNEW
« no previous file with comments | « no previous file | ui/base/material_design/material_design_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698