Remove Script::SetData and the script_data parameter from Script::(Compile|New).

Remove Script::SetData and the script_data parameter from Script::(Compile|New).

This feature makes it possible to associate data with a script and get it back
when the script is compiled or when an event is handled. It was historically
used by Chromium Dev Tools, but not any more. It is not used by node.js.

Note: this has nothing to do with the preparse data, despite the confusing name.
The preparse data is passed as ScriptData*.

R=svenpanne@chromium.org
BUG=

Committed: https://code.google.com/p/v8/source/detail?r=19616

[marja, 2014-02-28 11:08:23]

svenpanne, ptal

[marja, 2014-02-28 11:50:55]

Oops, no, I should probably remove the underlying level too. I'll upload a new
patch set shortly.

[marja, 2014-02-28 12:02:37]

alright, removed this from compilation API too.

[Sven Panne, 2014-02-28 12:48:27]

I think this CL is still incomplete: One has to remove the "data" field from
Script in objects.h and get things compiling again...

[marja, 2014-02-28 13:05:30]

... now removed also the internal data field from internal Script.

[Sven Panne, 2014-02-28 13:18:56]

LGTM with a nit, but I've added Yury: He should probably have a quick look at
the devtools-related side of this CL.

https://codereview.chromium.org/184403002/diff/40001/src/api.cc
File src/api.cc (left):

https://codereview.chromium.org/184403002/diff/40001/src/api.cc#oldcode1983
src/api.cc:1983: v8::Handle<Value> Message::GetScriptData() const {
Remove this from include/v8.h, too.

[marja, 2014-02-28 13:24:24]

Thanks for having a look!

I talked with yurys@ earlier today and we concluded that this script data
functionality is not used by dev tools any more, but it was replaced by using
Context::(Get|Set)EmbedderData. (The place where this was probably used in the
past is V8PerContextDebugData::setContextDebugData.)

https://codereview.chromium.org/184403002/diff/40001/src/api.cc
File src/api.cc (left):

https://codereview.chromium.org/184403002/diff/40001/src/api.cc#oldcode1983
src/api.cc:1983: v8::Handle<Value> Message::GetScriptData() const {
On 2014/02/28 13:18:56, Sven Panne wrote:
> Remove this from include/v8.h, too.

Done.

[marja, 2014-02-28 13:54:28]

Committed patchset #5 manually as r19616 (tree was closed).