Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 1844023003: [interpreter] Fix stale DCHECK in tracing. (Closed)

Created:
4 years, 8 months ago by oth
Modified:
4 years, 8 months ago
Reviewers:
mythria
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Adds test for tracing. Fixes a stale DCHECK and a memory leak in tracing output. LOG=N BUG=v8:4280 TBR=rmcilroy@chromium.org Committed: https://crrev.com/8cf73ae1e99b9adf5ec3aad66dae175c736ba188 Cr-Commit-Position: refs/heads/master@{#35161}

Patch Set 1 #

Patch Set 2 : Fix a memory leak and add test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+331 lines, -4 lines) Patch
M src/runtime/runtime-interpreter.cc View 1 2 chunks +6 lines, -4 lines 0 comments Download
A test/mjsunit/ignition/tracing.js View 1 1 chunk +325 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
oth
Mythri, PTAL. We should have a test for this, but need to figure out how ...
4 years, 8 months ago (2016-03-31 10:18:32 UTC) #2
oth
On 2016/03/31 10:18:32, oth wrote: > Mythri, PTAL. We should have a test for this, ...
4 years, 8 months ago (2016-03-31 11:08:28 UTC) #3
mythria
lgtm
4 years, 8 months ago (2016-03-31 11:15:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844023003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844023003/20001
4 years, 8 months ago (2016-03-31 11:54:26 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-31 11:56:07 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 11:58:10 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8cf73ae1e99b9adf5ec3aad66dae175c736ba188
Cr-Commit-Position: refs/heads/master@{#35161}

Powered by Google App Engine
This is Rietveld 408576698