Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4846)

Unified Diff: chrome/app/main_dll_loader_win.cc

Issue 1844023002: Capture a report on failed browser rendez-vous. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revise stats consent validation Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/app/main_dll_loader_win.cc
diff --git a/chrome/app/main_dll_loader_win.cc b/chrome/app/main_dll_loader_win.cc
index 8d8f978bd3f3702f464d8a5c1e0ed34cd66ee6a8..cf087e4447c0badcc544b6b1a0a02e6f55f149fc 100644
--- a/chrome/app/main_dll_loader_win.cc
+++ b/chrome/app/main_dll_loader_win.cc
@@ -224,8 +224,7 @@ void ChromeDllLoader::OnBeforeLaunch(const std::string& process_type,
// Launch the watcher process if stats collection consent has been granted.
#if defined(GOOGLE_CHROME_BUILD)
- const bool stats_collection_consent =
- GoogleUpdateSettings::GetCollectStatsConsent();
+ const bool stats_collection_consent = crash_reporter::GetUploadsEnabled();
scottmg 2016/04/08 15:52:25 Yes, this lgtm. You could collapse out the #if def
manzagop (departed) 2016/04/08 21:15:56 I think I understood what you meant, but please va
scottmg 2016/04/08 22:20:55 Yeah, that's what I meant, sorry for the terseness
#else
const bool stats_collection_consent = false;
#endif

Powered by Google App Engine
This is Rietveld 408576698