Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: third_party/WebKit/Source/core/frame/VisualViewport.cpp

Issue 1844013002: Fix main thread top controls scrolling to mirror CC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@propertyTreesBoundsDelta
Patch Set: Build fix after rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/VisualViewport.cpp
diff --git a/third_party/WebKit/Source/core/frame/VisualViewport.cpp b/third_party/WebKit/Source/core/frame/VisualViewport.cpp
index 7329a0a68faa68457bc1a32887e60ac6a888bd86..65b80677087df051fdbea24cfdaa560cdbee2220 100644
--- a/third_party/WebKit/Source/core/frame/VisualViewport.cpp
+++ b/third_party/WebKit/Source/core/frame/VisualViewport.cpp
@@ -565,7 +565,7 @@ DoublePoint VisualViewport::maximumScrollPositionDouble() const
if (!mainFrame())
return IntPoint();
- // FIXME: We probably shouldn't be storing the bounds in a float. crbug.com/422331.
+ // TODO(bokan): We probably shouldn't be storing the bounds in a float. crbug.com/470718.
FloatSize frameViewSize(contentsSize());
if (m_topControlsAdjustment) {
@@ -577,7 +577,7 @@ DoublePoint VisualViewport::maximumScrollPositionDouble() const
frameViewSize = FloatSize(flooredIntSize(frameViewSize));
FloatSize viewportSize(m_size);
- viewportSize.expand(0, m_topControlsAdjustment);
+ viewportSize.expand(0, ceilf(m_topControlsAdjustment));
FloatSize maxPosition = frameViewSize - viewportSize;
maxPosition.scale(1 / m_scale);
« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameView.h ('k') | third_party/WebKit/Source/web/ResizeViewportAnchor.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698