third_party/WebKit/Source/web/WebViewFrameWidget.h - Issue 1844013002: Fix main thread top controls scrolling to mirror CC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebViewFrameWidget.h

Issue 1844013002: Fix main thread top controls scrolling to mirror CC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@propertyTreesBoundsDelta

Patch Set: Fixed anchoring to check width too Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/web/WebPagePopupImpl.cpp ('k') | third_party/WebKit/Source/web/WebViewFrameWidget.cpp » ('j') | third_party/WebKit/Source/web/WebViewImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/WebViewFrameWidget.h

diff --git a/third_party/WebKit/Source/web/WebViewFrameWidget.h b/third_party/WebKit/Source/web/WebViewFrameWidget.h

index a8a76efb6cf8b28fcab1fcfe8f52cc836f3f4dd2..6497bc2874c1c5b10479547ac159e2b7152f6f32 100644

--- a/third_party/WebKit/Source/web/WebViewFrameWidget.h

+++ b/third_party/WebKit/Source/web/WebViewFrameWidget.h

@@ -41,6 +41,7 @@ public:

void close() override;

WebSize size() override;

void resize(const WebSize&) override;

+ void resize(const WebSize&, float topControlsHeight, bool topControlsShrinkLayoutViewportSize) override;

void resizeVisualViewport(const WebSize&) override;

void didEnterFullScreen() override;

void didExitFullScreen() override;

@@ -89,7 +90,6 @@ public:

void didChangeWindowResizerRect() override;

WebColor backgroundColor() const override;

WebPagePopup* pagePopup() const override;

- void setTopControlsHeight(float height, bool topControlsShrinkLayoutSize) override;

void updateTopControlsState(WebTopControlsState constraints, WebTopControlsState current, bool animate) override;

void setVisibilityState(WebPageVisibilityState, bool isInitialState) override;

bool isTransparent() const override;