Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.h

Issue 1844013002: Fix main thread top controls scrolling to mirror CC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@propertyTreesBoundsDelta
Patch Set: Override top controls resize() in classes that override resize() Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebViewImpl.h
diff --git a/third_party/WebKit/Source/web/WebViewImpl.h b/third_party/WebKit/Source/web/WebViewImpl.h
index a428bd4d4f0944c636d32bb8f4f0e7e1e809523b..010ea52ff6c1d2d8559af40a22c231bbb50e97a2 100644
--- a/third_party/WebKit/Source/web/WebViewImpl.h
+++ b/third_party/WebKit/Source/web/WebViewImpl.h
@@ -106,6 +106,7 @@ public:
// WebWidget methods:
void close() override;
WebSize size() override;
+ void resize(const WebSize&, float topControlsHeight, bool topControlsShrinkLayoutSize) override;
void resize(const WebSize&) override;
void resizeVisualViewport(const WebSize&) override;
void didEnterFullScreen() override;
@@ -501,7 +502,6 @@ public:
bool matchesHeuristicsForGpuRasterizationForTesting() const { return m_matchesHeuristicsForGpuRasterization; }
- void setTopControlsHeight(float height, bool topControlsShrinkLayoutSize) override;
void updateTopControlsState(WebTopControlsState constraint, WebTopControlsState current, bool animate) override;
TopControls& topControls();
@@ -545,7 +545,7 @@ private:
IntSize contentsSize() const;
void performResize();
- void resizeViewWhileAnchored(FrameView*);
+ void resizeViewWhileAnchored(FrameView*, float topControlsHeight, bool topControlsShrinkLayoutSize);
friend class WebView; // So WebView::Create can call our constructor
friend class WTF::RefCounted<WebViewImpl>;

Powered by Google App Engine
This is Rietveld 408576698