Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.h

Issue 1844013002: Fix main thread top controls scrolling to mirror CC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@propertyTreesBoundsDelta
Patch Set: Build fix after rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 (C) 1998 Waldo Bastian (bastian@kde.org) 3 (C) 1998 Waldo Bastian (bastian@kde.org)
4 (C) 1998, 1999 Torben Weis (weis@kde.org) 4 (C) 1998, 1999 Torben Weis (weis@kde.org)
5 (C) 1999 Lars Knoll (knoll@kde.org) 5 (C) 1999 Lars Knoll (knoll@kde.org)
6 (C) 1999 Antti Koivisto (koivisto@kde.org) 6 (C) 1999 Antti Koivisto (koivisto@kde.org)
7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed. 7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed.
8 8
9 This library is free software; you can redistribute it and/or 9 This library is free software; you can redistribute it and/or
10 modify it under the terms of the GNU Library General Public 10 modify it under the terms of the GNU Library General Public
(...skipping 343 matching lines...) Expand 10 before | Expand all | Expand 10 after
354 m_tickmarks = tickmarks; 354 m_tickmarks = tickmarks;
355 invalidatePaintForTickmarks(); 355 invalidatePaintForTickmarks();
356 } 356 }
357 357
358 void invalidatePaintForTickmarks(); 358 void invalidatePaintForTickmarks();
359 359
360 // Since the compositor can resize the viewport due to top controls and 360 // Since the compositor can resize the viewport due to top controls and
361 // commit scroll offsets before a WebView::resize occurs, we need to adjust 361 // commit scroll offsets before a WebView::resize occurs, we need to adjust
362 // our scroll extents to prevent clamping the scroll offsets. 362 // our scroll extents to prevent clamping the scroll offsets.
363 void setTopControlsViewportAdjustment(float); 363 void setTopControlsViewportAdjustment(float);
364 IntSize topControlsSize() const { return IntSize(0, roundf(m_topControlsView portAdjustment)); } 364 IntSize topControlsSize() const { return IntSize(0, ceilf(m_topControlsViewp ortAdjustment)); }
365 365
366 IntPoint maximumScrollPosition() const override; 366 IntPoint maximumScrollPosition() const override;
367 367
368 // ScrollableArea interface 368 // ScrollableArea interface
369 void scrollControlWasSetNeedsPaintInvalidation() override { } 369 void scrollControlWasSetNeedsPaintInvalidation() override { }
370 void getTickmarks(Vector<IntRect>&) const override; 370 void getTickmarks(Vector<IntRect>&) const override;
371 IntRect scrollableAreaBoundingBox() const override; 371 IntRect scrollableAreaBoundingBox() const override;
372 bool scrollAnimatorEnabled() const override; 372 bool scrollAnimatorEnabled() const override;
373 bool usesCompositedScrolling() const override; 373 bool usesCompositedScrolling() const override;
374 bool shouldScrollOnMainThread() const override; 374 bool shouldScrollOnMainThread() const override;
(...skipping 555 matching lines...) Expand 10 before | Expand all | Expand 10 after
930 if (m_visuallyNonEmptyPixelCount > visualPixelThreshold) 930 if (m_visuallyNonEmptyPixelCount > visualPixelThreshold)
931 setIsVisuallyNonEmpty(); 931 setIsVisuallyNonEmpty();
932 } 932 }
933 933
934 DEFINE_TYPE_CASTS(FrameView, Widget, widget, widget->isFrameView(), widget.isFra meView()); 934 DEFINE_TYPE_CASTS(FrameView, Widget, widget, widget->isFrameView(), widget.isFra meView());
935 DEFINE_TYPE_CASTS(FrameView, ScrollableArea, scrollableArea, scrollableArea->isF rameView(), scrollableArea.isFrameView()); 935 DEFINE_TYPE_CASTS(FrameView, ScrollableArea, scrollableArea, scrollableArea->isF rameView(), scrollableArea.isFrameView());
936 936
937 } // namespace blink 937 } // namespace blink
938 938
939 #endif // FrameView_h 939 #endif // FrameView_h
OLDNEW
« no previous file with comments | « content/renderer/render_widget.cc ('k') | third_party/WebKit/Source/core/frame/VisualViewport.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698