Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: content/renderer/render_widget.cc

Issue 1844013002: Fix main thread top controls scrolling to mirror CC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@propertyTreesBoundsDelta
Patch Set: Override top controls resize() in classes that override resize() Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/render_widget.h" 5 #include "content/renderer/render_widget.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/auto_reset.h" 9 #include "base/auto_reset.h"
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 1118 matching lines...) Expand 10 before | Expand all | Expand 10 after
1129 top_controls_height_ = params.top_controls_height; 1129 top_controls_height_ = params.top_controls_height;
1130 visible_viewport_size_ = params.visible_viewport_size; 1130 visible_viewport_size_ = params.visible_viewport_size;
1131 resizer_rect_ = params.resizer_rect; 1131 resizer_rect_ = params.resizer_rect;
1132 1132
1133 // NOTE: We may have entered fullscreen mode without changing our size. 1133 // NOTE: We may have entered fullscreen mode without changing our size.
1134 bool fullscreen_change = 1134 bool fullscreen_change =
1135 is_fullscreen_granted_ != params.is_fullscreen_granted; 1135 is_fullscreen_granted_ != params.is_fullscreen_granted;
1136 is_fullscreen_granted_ = params.is_fullscreen_granted; 1136 is_fullscreen_granted_ = params.is_fullscreen_granted;
1137 display_mode_ = params.display_mode; 1137 display_mode_ = params.display_mode;
1138 1138
1139 webwidget_->setTopControlsHeight(params.top_controls_height,
1140 top_controls_shrink_blink_size_);
1141
1142 if (resized) { 1139 if (resized) {
1143 gfx::Size new_widget_size = size_; 1140 gfx::Size new_widget_size = size_;
1144 if (IsUseZoomForDSFEnabled()) { 1141 if (IsUseZoomForDSFEnabled()) {
1145 new_widget_size = gfx::ScaleToCeiledSize(new_widget_size, 1142 new_widget_size = gfx::ScaleToCeiledSize(new_widget_size,
1146 GetOriginalDeviceScaleFactor()); 1143 GetOriginalDeviceScaleFactor());
1147 } 1144 }
1148 // When resizing, we want to wait to paint before ACK'ing the resize. This 1145 // When resizing, we want to wait to paint before ACK'ing the resize. This
1149 // ensures that we only resize as fast as we can paint. We only need to 1146 // ensures that we only resize as fast as we can paint. We only need to
1150 // send an ACK if we are resized to a non-empty rect. 1147 // send an ACK if we are resized to a non-empty rect.
1151 webwidget_->resize(new_widget_size); 1148 webwidget_->resize(
1149 new_widget_size,
1150 top_controls_height_,
1151 top_controls_shrink_blink_size_);
majidvp 2016/04/06 18:07:30 I think for the top control anchoring to work corr
bokan 2016/04/06 19:23:35 We already do this in WebViewImpl::performResize.
1152 } 1152 }
1153 WebSize visual_viewport_size; 1153 WebSize visual_viewport_size;
1154 1154
1155 if (IsUseZoomForDSFEnabled()) { 1155 if (IsUseZoomForDSFEnabled()) {
1156 visual_viewport_size = gfx::ScaleToCeiledSize( 1156 visual_viewport_size = gfx::ScaleToCeiledSize(
1157 params.visible_viewport_size, 1157 params.visible_viewport_size,
1158 GetOriginalDeviceScaleFactor()); 1158 GetOriginalDeviceScaleFactor());
1159 } else { 1159 } else {
1160 visual_viewport_size = visible_viewport_size_; 1160 visual_viewport_size = visible_viewport_size_;
1161 } 1161 }
(...skipping 986 matching lines...) Expand 10 before | Expand all | Expand 10 after
2148 } 2148 }
2149 2149
2150 float RenderWidget::GetOriginalDeviceScaleFactor() const { 2150 float RenderWidget::GetOriginalDeviceScaleFactor() const {
2151 return 2151 return
2152 screen_metrics_emulator_ ? 2152 screen_metrics_emulator_ ?
2153 screen_metrics_emulator_->original_screen_info().deviceScaleFactor : 2153 screen_metrics_emulator_->original_screen_info().deviceScaleFactor :
2154 device_scale_factor_; 2154 device_scale_factor_;
2155 } 2155 }
2156 2156
2157 } // namespace content 2157 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698