Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Side by Side Diff: third_party/WebKit/Source/web/ResizeViewportAnchor.cpp

Issue 1844013002: Fix main thread top controls scrolling to mirror CC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@propertyTreesBoundsDelta
Patch Set: Whitespace Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "web/ResizeViewportAnchor.h" 5 #include "web/ResizeViewportAnchor.h"
6 6
7 #include "core/frame/FrameView.h" 7 #include "core/frame/FrameView.h"
8 #include "core/frame/VisualViewport.h" 8 #include "core/frame/VisualViewport.h"
9 #include "platform/geometry/DoubleRect.h" 9 #include "platform/geometry/DoubleRect.h"
10 #include "platform/geometry/DoubleSize.h" 10 #include "platform/geometry/DoubleSize.h"
11 #include "platform/geometry/FloatSize.h" 11 #include "platform/geometry/FloatSize.h"
12 12
13 namespace blink { 13 namespace blink {
14 14
15 ResizeViewportAnchor::ResizeViewportAnchor(FrameView& rootFrameView, VisualViewp ort& visualViewport) 15 ResizeViewportAnchor::ResizeViewportAnchor(FrameView& rootFrameView, VisualViewp ort& visualViewport)
16 : ViewportAnchor(rootFrameView, visualViewport) 16 : ViewportAnchor(rootFrameView, visualViewport)
17 , m_visualViewportInDocument(rootFrameView.getScrollableArea()->visibleConte ntRectDouble().location()) 17 , m_visualViewportInDocument(rootFrameView.getScrollableArea()->scrollPositi onDouble())
18 { 18 {
19 } 19 }
20 20
21 ResizeViewportAnchor::~ResizeViewportAnchor() 21 ResizeViewportAnchor::~ResizeViewportAnchor()
22 { 22 {
23 m_rootFrameView->getScrollableArea()->setScrollPosition(m_visualViewportInDo cument, ProgrammaticScroll); 23 // TODO(bokan): Don't use RootFrameViewport::setScrollPosition since it
24 // assumes we can just set a sub-pixel precision offset on the FrameView.
25 // While we "can" do this, the offset that will be shipped to CC will be the
26 // truncated number and this class is used to handle TopControl movement
27 // which needs the two threads to match exactly pixel-for-pixel. We can
28 // replace this with RFV::setScrollPosition once Blink is sub-pixel scroll
29 // offset aware. crbug.com/414283.
30
31 ScrollableArea* rootViewport = m_rootFrameView->getScrollableArea();
32 ScrollableArea* layoutViewport =
33 m_rootFrameView->layoutViewportScrollableArea();
34
35 DoubleSize delta = m_visualViewportInDocument
36 - rootViewport->scrollPositionDouble();
37
38 m_visualViewport->move(toFloatSize(delta));
39
40 // Since the main thread FrameView has integer scroll offsets, scroll it to
41 // the next pixel and then we'll scroll the visual viewport again to
42 // compensate for the sub-pixel offset.
43 delta = m_visualViewportInDocument
44 - rootViewport->scrollPositionDouble();
45
46 IntSize layoutDelta = delta.height() < 0
47 ? flooredIntSize(delta)
48 : expandedIntSize(delta);
49
50 layoutViewport->setScrollPosition(
51 layoutViewport->scrollPosition() + layoutDelta,
52 ProgrammaticScroll);
53
54 delta = m_visualViewportInDocument
55 - rootViewport->scrollPositionDouble();
56 m_visualViewport->move(toFloatSize(delta));
24 } 57 }
25 58
26 } // namespace blink 59 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698