Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1844003003: Fix MdTextButton colors in incognito windows. (Closed)

Created:
4 years, 8 months ago by Evan Stade
Modified:
4 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix MdTextButton colors in incognito windows. BUG=598541 Committed: https://crrev.com/1e11d95dbbbf692ac14617db7572aa0f87029f03 Cr-Commit-Position: refs/heads/master@{#384662}

Patch Set 1 #

Patch Set 2 : enumerate all colors #

Patch Set 3 : compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -1 line) Patch
M ui/native_theme/native_theme_dark_aura.cc View 1 2 2 chunks +64 lines, -1 line 0 comments Download

Messages

Total messages: 21 (9 generated)
Evan Stade
4 years, 8 months ago (2016-03-30 23:50:39 UTC) #2
sky
LGTM - is it worth a test to ensure that when new values added the ...
4 years, 8 months ago (2016-03-31 01:11:12 UTC) #3
Evan Stade
On 2016/03/31 01:11:12, sky wrote: > LGTM - is it worth a test to ensure ...
4 years, 8 months ago (2016-03-31 02:15:21 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844003003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844003003/1
4 years, 8 months ago (2016-03-31 02:15:23 UTC) #6
sky
Removal of default case gets the test for free. So, I vote that. On Wed, ...
4 years, 8 months ago (2016-03-31 02:29:46 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/151261)
4 years, 8 months ago (2016-03-31 02:38:06 UTC) #9
Evan Stade
On 2016/03/31 02:29:46, sky wrote: > Removal of default case gets the test for free. ...
4 years, 8 months ago (2016-03-31 19:23:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844003003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844003003/20001
4 years, 8 months ago (2016-03-31 19:24:00 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/114658) chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 8 months ago (2016-03-31 19:47:34 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844003003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844003003/40001
4 years, 8 months ago (2016-04-01 17:53:04 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-01 19:37:42 UTC) #19
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 19:39:53 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1e11d95dbbbf692ac14617db7572aa0f87029f03
Cr-Commit-Position: refs/heads/master@{#384662}

Powered by Google App Engine
This is Rietveld 408576698