|
|
Chromium Code Reviews|
Created:
4 years, 8 months ago by Evan Stade Modified:
4 years, 8 months ago Reviewers:
sky CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix MdTextButton colors in incognito windows.
BUG=598541
Committed: https://crrev.com/1e11d95dbbbf692ac14617db7572aa0f87029f03
Cr-Commit-Position: refs/heads/master@{#384662}
Patch Set 1 #Patch Set 2 : enumerate all colors #Patch Set 3 : compile #Messages
Total messages: 21 (9 generated)
estade@chromium.org changed reviewers: + sky@chromium.org
LGTM - is it worth a test to ensure that when new values added the switch is updated?
The CQ bit was checked by estade@chromium.org to run a CQ dry run
On 2016/03/31 01:11:12, sky wrote: > LGTM - is it worth a test to ensure that when new values added the switch is > updated? would you rather see a test or removal of the default case?
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844003003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844003003/1
Removal of default case gets the test for free. So, I vote that. On Wed, Mar 30, 2016 at 7:15 PM, <estade@chromium.org> wrote: > On 2016/03/31 01:11:12, sky wrote: >> LGTM - is it worth a test to ensure that when new values added the switch >> is >> updated? > > would you rather see a test or removal of the default case? > > https://codereview.chromium.org/1844003003/ -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
On 2016/03/31 02:29:46, sky wrote: > Removal of default case gets the test for free. So, I vote that. > > On Wed, Mar 30, 2016 at 7:15 PM, <mailto:estade@chromium.org> wrote: > > On 2016/03/31 01:11:12, sky wrote: > >> LGTM - is it worth a test to ensure that when new values added the switch > >> is > >> updated? > > > > would you rather see a test or removal of the default case? > > > > https://codereview.chromium.org/1844003003/ > > -- > You received this message because you are subscribed to the Google Groups > "Chromium-reviews" group. > To unsubscribe from this group and stop receiving emails from it, send an email > to mailto:chromium-reviews+unsubscribe@chromium.org. > done. Sticking in CQ.
The CQ bit was checked by estade@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org Link to the patchset: https://codereview.chromium.org/1844003003/#ps20001 (title: "enumerate all colors")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844003003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844003003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...) chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
The CQ bit was checked by estade@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org Link to the patchset: https://codereview.chromium.org/1844003003/#ps40001 (title: "compile")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844003003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844003003/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Fix MdTextButton colors in incognito windows. BUG=598541 ========== to ========== Fix MdTextButton colors in incognito windows. BUG=598541 Committed: https://crrev.com/1e11d95dbbbf692ac14617db7572aa0f87029f03 Cr-Commit-Position: refs/heads/master@{#384662} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/1e11d95dbbbf692ac14617db7572aa0f87029f03 Cr-Commit-Position: refs/heads/master@{#384662} |
