Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(861)

Unified Diff: telemetry/telemetry/testing/run_tests.py

Issue 1843963002: [Telemetry] Disable DISABLE_CLOUD_STORAGE_IO before each test process run (Closed) Base URL: https://github.com/catapult-project/catapult@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/testing/run_tests.py
diff --git a/telemetry/telemetry/testing/run_tests.py b/telemetry/telemetry/testing/run_tests.py
index 47fefa35e3c6aad2e91e05bb8e1fa36cad79df7c..7e8d6ee37ee6c30cd2adb6ac89a325ac3cba09ee 100644
--- a/telemetry/telemetry/testing/run_tests.py
+++ b/telemetry/telemetry/testing/run_tests.py
@@ -2,7 +2,6 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-import os
import logging
import sys
@@ -19,7 +18,6 @@ from telemetry.internal.util import ps_util
from telemetry.testing import browser_test_case
from telemetry.testing import options_for_unittests
-from catapult_base import cloud_storage
from catapult_base import xvfb
import typ
@@ -236,7 +234,10 @@ def _SetUpProcess(child, context): # pylint: disable=unused-argument
ps_util.EnableListingStrayProcessesUponExitHook()
# Make sure that we don't invokes cloud storage I/Os when we run the tests in
# parallel.
- os.environ[cloud_storage.DISABLE_CLOUD_STORAGE_IO] = '1'
+ # TODO(nednguyen): Enabled this once telemetry tests in Chromium is updated
+ # to prefetch files.
+ # (https://github.com/catapult-project/catapult/issues/2192)
+ # os.environ[cloud_storage.DISABLE_CLOUD_STORAGE_IO] = '1'
if binary_manager.NeedsInit():
# Typ doesn't keep the DependencyManager initialization in the child
# processes.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698