Add ColorspaceConversion to createImageBitmap(HTMLImageElement)

Add ColorspaceConversion to createImageBitmap(HTMLImageElement)

The ColorspaceConversion option has been added to createImageBitmap(Blob)
and the corresponding layout test has been added too.

This CL adds this option to createImageBitmap(HTMLImageElement) and also
modify an existing layout test so that this option is effective.

BUG=592005
Committed: https://crrev.com/514c171c54f89d92c33e454b410fcd404039880e
Cr-Commit-Position: refs/heads/master@{#386446}

[xidachen, 2016-03-30 15:14:26]

xidachen@chromium.org changed reviewers:
+ junov@chromium.org

[xidachen, 2016-03-30 15:14:27]

PTAL

[Justin Novosad, 2016-03-30 16:03:20]

https://codereview.chromium.org/1843953003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/canvas/webgl/tex-image-and-sub-image-2d-image-bitmap-from-image.html
(right):

https://codereview.chromium.org/1843953003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/webgl/tex-image-and-sub-image-2d-image-bitmap-from-image.html:76:
image2.onload = function() {
This is a recipe for flakiness. There is no strict guarantee that images will be
loaded in a deterministic order. You want something like this: 
var loadedImages = 0;
image1.onload = image2.onload = function() {
  if (++loadedImages == 2) {
    generateTest();
  }
}

https://codereview.chromium.org/1843953003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/ImageBitmap.cpp (right):

https://codereview.chromium.org/1843953003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/ImageBitmap.cpp:124: premultiplyAlpha ?
ImageDecoder::AlphaPremultiplied : ImageDecoder::AlphaNotPremultiplied,
Not new to this CL, but could you clarify the difference between alphaOp and
premultiplyAlpha? I am have trouble following this. Code needs to be cleaned-up
for readability.

[xidachen, 2016-03-30 17:36:03]

https://codereview.chromium.org/1843953003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/ImageBitmap.cpp (right):

https://codereview.chromium.org/1843953003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/ImageBitmap.cpp:124: premultiplyAlpha ?
ImageDecoder::AlphaPremultiplied : ImageDecoder::AlphaNotPremultiplied,
On 2016/03/30 16:03:20, Justin Novosad wrote:
> Not new to this CL, but could you clarify the difference between alphaOp and
> premultiplyAlpha? I am have trouble following this. Code needs to be
cleaned-up
> for readability.

The parameter "premultiplyAlpha" indicates whether we want the created
ImageBitmap to be in premultiplied or unpremultiplied format.

"alphaOp" is specifically designed for createImageBitmap from ImageBitmap and
Blob. For example, when we do ImageBitmap2 = createImageBitmap(ImageBitmap1,
premultiplyAlpha=false), and ImageBitmap1 is already unpremultiplied format, we
don't want to use decoder to decode it again.

[xidachen, 2016-03-30 17:45:30]

https://codereview.chromium.org/1843953003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/ImageBitmap.cpp (right):

https://codereview.chromium.org/1843953003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/ImageBitmap.cpp:124: premultiplyAlpha ?
ImageDecoder::AlphaPremultiplied : ImageDecoder::AlphaNotPremultiplied,
On 2016/03/30 16:03:20, Justin Novosad wrote:
> Not new to this CL, but could you clarify the difference between alphaOp and
> premultiplyAlpha? I am have trouble following this. Code needs to be
cleaned-up
> for readability.

Maybe change the "alphaOp" to "imageFormat" to indicate the format of the first
parameter "image", whether it is premultiplied or unpremultiplied?

[xidachen, 2016-04-11 17:09:43]

junov@: This CL was somehow buried, could you take a look?

[Justin Novosad, 2016-04-11 17:22:22]

lgtm

[xidachen, 2016-04-11 17:23:55]

The CQ bit was checked by xidachen@chromium.org

[commit-bot: I haz the power, 2016-04-11 17:24:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1843953003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1843953003/20001

[commit-bot: I haz the power, 2016-04-11 19:53:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-11 19:55:12]

Description was changed from

==========
Add ColorspaceConversion to createImageBitmap(HTMLImageElement)

The ColorspaceConversion option has been added to createImageBitmap(Blob)
and the corresponding layout test has been added too.

This CL adds this option to createImageBitmap(HTMLImageElement) and also
modify an existing layout test so that this option is effective.

BUG=592005
==========

to

==========
Add ColorspaceConversion to createImageBitmap(HTMLImageElement)

The ColorspaceConversion option has been added to createImageBitmap(Blob)
and the corresponding layout test has been added too.

This CL adds this option to createImageBitmap(HTMLImageElement) and also
modify an existing layout test so that this option is effective.

BUG=592005

Committed: https://crrev.com/514c171c54f89d92c33e454b410fcd404039880e
Cr-Commit-Position: refs/heads/master@{#386446}
==========

[commit-bot: I haz the power, 2016-04-11 19:55:13]

Patchset 2 (id:??) landed as
https://crrev.com/514c171c54f89d92c33e454b410fcd404039880e
Cr-Commit-Position: refs/heads/master@{#386446}