chrome/browser/ui/browser_navigator.cc - Issue 1843943003: Extension-created windows should share the creator's BrowingInstance.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_navigator.cc

Issue 1843943003: Extension-created windows should share the creator's BrowingInstance. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/window_open_apitest.cc ('k') | chrome/test/data/extensions/api_test/window_open/panel_browsing_instance/background.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/browser_navigator.cc

diff --git a/chrome/browser/ui/browser_navigator.cc b/chrome/browser/ui/browser_navigator.cc

index 75ab0792ea2d055f39793ca172452caf3132aecf..746e8f5d06e9f8e002b2f9c3cfac95e30cad9fb2 100644

--- a/chrome/browser/ui/browser_navigator.cc

+++ b/chrome/browser/ui/browser_navigator.cc

@@ -338,7 +338,9 @@ content::WebContents* CreateTargetContents(const chrome::NavigateParams& params,

const GURL& url) {

WebContents::CreateParams create_params(

params.browser->profile(),

- tab_util::GetSiteInstanceForNewTab(params.browser->profile(), url));

+ params.source_site_instance

+ ? params.source_site_instance

+ : tab_util::GetSiteInstanceForNewTab(params.browser->profile(), url));

if (params.source_contents) {

create_params.initial_size =

params.source_contents->GetContainerBounds().size();