Extension-created windows should share the creator's BrowingInstance.

chrome/browser/extensions/api/tabs/tabs_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/tabs/tabs_api.h"
 
 #include <stddef.h>
 #include <algorithm>
 #include <limits>
 #include <utility>
@@ skipping 24 matching lines @@
 #include "chrome/browser/prefs/incognito_mode_prefs.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/sessions/session_tab_helper.h"
 #include "chrome/browser/translate/chrome_translate_client.h"
 #include "chrome/browser/ui/apps/chrome_app_delegate.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_commands.h"
 #include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/browser_list.h"
 #include "chrome/browser/ui/browser_navigator.h"
+#include "chrome/browser/ui/browser_navigator_params.h"
 #include "chrome/browser/ui/browser_tabstrip.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/panels/panel_manager.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/browser/ui/tabs/tab_utils.h"
 #include "chrome/browser/ui/window_sizer/window_sizer.h"
 #include "chrome/browser/web_applications/web_app.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/extensions/api/tabs.h"
 #include "chrome/common/extensions/api/windows.h"
@@ skipping 579 matching lines @@
         false /* trusted_source */, window_bounds, window_profile);
   }
   create_params.initial_show_state = ui::SHOW_STATE_NORMAL;
   if (create_data && create_data->state) {
     create_params.initial_show_state =
         ConvertToWindowShowState(create_data->state);
   }
 
   Browser* new_window = new Browser(create_params);
 
-  for (std::vector<GURL>::iterator i = urls.begin(); i != urls.end(); ++i) {
-    WebContents* tab = chrome::AddSelectedTabWithURL(

[Devlin, 2016/04/01 17:20:57]

Do we still need browser_tabstrip.h?

[dcheng, 2016/04/01 17:42:00]

Done.

-        new_window, *i, ui::PAGE_TRANSITION_LINK);
+  for (const GURL& url : urls) {
+    chrome::NavigateParams navigate_params(new_window, url,
+                                           ui::PAGE_TRANSITION_LINK);
+    navigate_params.disposition = NEW_FOREGROUND_TAB;
+    navigate_params.source_site_instance =

[Devlin, 2016/04/01 17:20:57]

"Without plumbing through the source SiteInstance, the created window
ends up cross process and unscriptable by the background page that
created it."

I'm not quite sure I follow - don't we sometimes (often) want that?  If an
extension creates a window that has urls to google.com, facebook.com, and
yourbank.com, why would we want that in the same process and scriptable?

[dcheng, 2016/04/01 17:42:00]

It'd cause a navigation from an extension origin to a web origin, which should
process swap. What's broken is if an extension navigates to its own resource, it
can't script itself even though it should be in a 'related browsing context'.

[Devlin, 2016/04/01 18:56:34]

Ah, got it - can you add that to the CL description?

[dcheng, 2016/04/02 00:54:25]

Done.

+        render_frame_host()->GetSiteInstance();
+    chrome::Navigate(&navigate_params);
     if (create_panel) {
-      TabHelper::FromWebContents(tab)->SetExtensionAppIconById(extension_id);
+      TabHelper::FromWebContents(navigate_params.target_contents)
+          ->SetExtensionAppIconById(extension_id);
     }
   }
 
   WebContents* contents = NULL;
   // Move the tab into the created window only if it's an empty popup or it's
   // a tabbed window.
   if ((window_type == Browser::TYPE_POPUP && urls.empty()) ||
       window_type == Browser::TYPE_TABBED) {
     if (source_tab_strip)
       contents = source_tab_strip->DetachWebContentsAt(tab_index);
@@ skipping 1472 matching lines @@
   ZoomModeToZoomSettings(zoom_mode, &zoom_settings);
   zoom_settings.default_zoom_factor.reset(new double(
       content::ZoomLevelToZoomFactor(zoom_controller->GetDefaultZoomLevel())));
 
   results_ = api::tabs::GetZoomSettings::Results::Create(zoom_settings);
   SendResponse(true);
   return true;
 }
 
 }  // namespace extensions