Extension-created windows should share the creator's BrowingInstance.

chrome/browser/extensions/window_open_apitest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include "base/command_line.h"
 #include "base/memory/scoped_vector.h"
 #include "base/path_service.h"
 #include "base/strings/stringprintf.h"
@@ skipping 213 matching lines @@
   EXPECT_TRUE(WaitForTabsAndPopups(browser(), 3, 1, 0));
 }
 
 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, WindowArgumentsOverflow) {
   ASSERT_TRUE(RunExtensionTest("window_open/argument_overflow")) << message_;
 }
 
 class WindowOpenPanelDisabledTest : public ExtensionApiTest {
   void SetUpCommandLine(base::CommandLine* command_line) override {
     ExtensionApiTest::SetUpCommandLine(command_line);
-    // TODO(jennb): Re-enable when panels are enabled by default.
-    // command_line->AppendSwitch(switches::kDisablePanels);
+    command_line->AppendSwitch(switches::kDisablePanels);
   }
 };
 
-IN_PROC_BROWSER_TEST_F(WindowOpenPanelDisabledTest,
-                       DISABLED_WindowOpenPanelNotEnabled) {
+IN_PROC_BROWSER_TEST_F(WindowOpenPanelDisabledTest, WindowOpenPanelNotEnabled) {
   ASSERT_TRUE(RunExtensionTest("window_open/panel_not_enabled")) << message_;
 }
 
 class WindowOpenPanelTest : public ExtensionApiTest {
   void SetUpCommandLine(base::CommandLine* command_line) override {
     ExtensionApiTest::SetUpCommandLine(command_line);
     command_line->AppendSwitch(switches::kEnablePanels);
   }
 };
 
@@ skipping 23 matching lines @@
 // |   |                     | <--------------/                         | |
 // |   +---------------------+   |    | +-------------------------------+ |
 // |                             |    |                                   |
 // +-----------------------------+    +-----------------------------------+
 //
 // See also crbug.com/568357 for more info / context.
 IN_PROC_BROWSER_TEST_F(WindowOpenPanelTest, BrowsingInstanceTest) {
   host_resolver()->AddRule("*", "127.0.0.1");
   ASSERT_TRUE(StartEmbeddedTestServer());
 
-  ASSERT_TRUE(RunExtensionTest("window_open/panel_browsing_instance"))
+  ASSERT_TRUE(
+      RunExtensionTestWithArg("window_open/panel_browsing_instance", "panel"))
       << message_;
 }
 
+// Similar to the previous test, but for when panels are disabled.
+IN_PROC_BROWSER_TEST_F(WindowOpenPanelDisabledTest, BrowsingInstanceTest) {
+  host_resolver()->AddRule("*", "127.0.0.1");
+  ASSERT_TRUE(StartEmbeddedTestServer());
+
+  ASSERT_TRUE(
+      RunExtensionTestWithArg("window_open/panel_browsing_instance", "popup"))
+      << message_;
+}
+
 #if defined(USE_ASH_PANELS) || defined(OS_LINUX)
 // On Ash, this currently fails because we're currently opening new panel
 // windows as popup windows instead.
 // We're also failing on Linux-aura due to the panel is not opened in the
 // right origin.
 #define MAYBE_WindowOpenPanelDetached DISABLED_WindowOpenPanelDetached
 #else
 #define MAYBE_WindowOpenPanelDetached WindowOpenPanelDetached
 #endif
 IN_PROC_BROWSER_TEST_F(WindowOpenPanelTest, MAYBE_WindowOpenPanelDetached) {
@@ skipping 231 matching lines @@
                      last_loaded_extension_id() + "/newtab.html"),
                  false,
                  &newtab));
 
   // Extension API should succeed.
   bool result = false;
   ASSERT_TRUE(content::ExecuteScriptAndExtractBool(newtab, "testExtensionApi()",
                                                    &result));
   EXPECT_TRUE(result);
 }