Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 1843933002: [stubs] Migrate ToLengthStub to TurboFan. (Closed)

Created:
4 years, 8 months ago by Benedikt Meurer
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@MathCeil
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Migrate ToLengthStub to TurboFan. We now have everything in place to fully implement ToLengthStub as TurboFanCodeStub without any runtime fallback (modulo allocation failure of course). R=jarin@chromium.org Committed: https://crrev.com/2c653a5deec28f80dcdd1038298bd884a809d4c2 Cr-Commit-Position: refs/heads/master@{#35137}

Patch Set 1 #

Patch Set 2 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -169 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M src/code-stubs.h View 4 chunks +9 lines, -9 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +77 lines, -0 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M src/s390/code-stubs-s390.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 8 months ago (2016-03-30 12:24:11 UTC) #1
Benedikt Meurer
Hey Jaro, Here's a simple refactoring of ToLengthStub. Please take a look. Thanks, Benedikt
4 years, 8 months ago (2016-03-30 12:26:15 UTC) #2
Jarin
lgtm
4 years, 8 months ago (2016-03-30 12:30:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1843933002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1843933002/20001
4 years, 8 months ago (2016-03-30 12:33:12 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-30 12:49:12 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 12:51:16 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2c653a5deec28f80dcdd1038298bd884a809d4c2
Cr-Commit-Position: refs/heads/master@{#35137}

Powered by Google App Engine
This is Rietveld 408576698