components/offline_pages/offline_page_archiver.h - Issue 1843893002: Support resaving offline page right after it is being deleted

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/offline_page_archiver.h

Issue 1843893002: Support resaving offline page right after it is being deleted (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address feedback Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/offline_pages/offline_page_mhtml_archiver_unittest.cc ('k') | components/offline_pages/offline_page_model.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/offline_page_archiver.h

diff --git a/components/offline_pages/offline_page_archiver.h b/components/offline_pages/offline_page_archiver.h

index 5a412a1d8b2311ed93f7998d7919eea5a9cf6c46..72fb8fdd92d523b07f571f9cc37f74b6109e28cf 100644

--- a/components/offline_pages/offline_page_archiver.h

+++ b/components/offline_pages/offline_page_archiver.h

@@ -64,9 +64,11 @@ class OfflinePageArchiver {

virtual ~OfflinePageArchiver() {}

- // Starts creating the archive in the |archives_dir|. Once archive is created

- // |callback| will be called with the result and additional information.

+ // Starts creating the archive in the |archives_dir| with |archive_id| added

+ // to the archive filename. Once archive is created |callback| will be called

+ // with the result and additional information.

virtual void CreateArchive(const base::FilePath& archives_dir,

+ int64_t archive_id,

const CreateArchiveCallback& callback) = 0;

};