Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1931)

Unified Diff: chrome/browser/android/offline_pages/offline_page_mhtml_archiver.h

Issue 1843893002: Support resaving offline page right after it is being deleted (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address feedback Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/offline_pages/offline_page_mhtml_archiver.h
diff --git a/chrome/browser/android/offline_pages/offline_page_mhtml_archiver.h b/chrome/browser/android/offline_pages/offline_page_mhtml_archiver.h
index bcc530ab0d388c70d0c74fc6a12e8b4e76a5b294..64d67e4bcba4b3c7347ca7ee9f73192f65104445 100644
--- a/chrome/browser/android/offline_pages/offline_page_mhtml_archiver.h
+++ b/chrome/browser/android/offline_pages/offline_page_mhtml_archiver.h
@@ -48,13 +48,15 @@ class OfflinePageMHTMLArchiver : public OfflinePageArchiver {
// Creates a file name for the archive file based on url and title. Public for
// testing.
static base::FilePath GenerateFileName(const GURL& url,
- const std::string& title);
+ const std::string& title,
+ int64_t archive_id);
explicit OfflinePageMHTMLArchiver(content::WebContents* web_contents);
~OfflinePageMHTMLArchiver() override;
// OfflinePageArchiver implementation:
void CreateArchive(const base::FilePath& archives_dir,
+ int64_t archive_id,
const CreateArchiveCallback& callback) override;
protected:
@@ -63,7 +65,8 @@ class OfflinePageMHTMLArchiver : public OfflinePageArchiver {
// Try to generate MHTML.
// Might be overridden for testing purpose.
- virtual void GenerateMHTML(const base::FilePath& archives_dir);
+ virtual void GenerateMHTML(const base::FilePath& archives_dir,
+ int64_t archive_id);
// Callback for Generating MHTML.
void OnGenerateMHTMLDone(const GURL& url,
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698