chrome/browser/android/offline_pages/offline_page_mhtml_archiver.h - Issue 1843893002: Support resaving offline page right after it is being deleted

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/offline_page_mhtml_archiver.h

Issue 1843893002: Support resaving offline page right after it is being deleted (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc » ('j') | chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/offline_pages/offline_page_mhtml_archiver.h

diff --git a/chrome/browser/android/offline_pages/offline_page_mhtml_archiver.h b/chrome/browser/android/offline_pages/offline_page_mhtml_archiver.h

index bcc530ab0d388c70d0c74fc6a12e8b4e76a5b294..8d3cf27bc595073414560535ed173591dfe6bbb2 100644

--- a/chrome/browser/android/offline_pages/offline_page_mhtml_archiver.h

+++ b/chrome/browser/android/offline_pages/offline_page_mhtml_archiver.h

@@ -48,13 +48,15 @@ class OfflinePageMHTMLArchiver : public OfflinePageArchiver {

// Creates a file name for the archive file based on url and title. Public for

// testing.

static base::FilePath GenerateFileName(const GURL& url,

- const std::string& title);

+ const std::string& title,

+ int64_t id);

fgorski 2016/03/30 01:43:30 nit: be consistent with naming, especially if this

jianli 2016/03/31 21:02:42 Done.

explicit OfflinePageMHTMLArchiver(content::WebContents* web_contents);

~OfflinePageMHTMLArchiver() override;

// OfflinePageArchiver implementation:

void CreateArchive(const base::FilePath& archives_dir,

+ int64_t archive_id,

const CreateArchiveCallback& callback) override;

protected:

@@ -63,7 +65,8 @@ class OfflinePageMHTMLArchiver : public OfflinePageArchiver {

// Try to generate MHTML.

// Might be overridden for testing purpose.

- virtual void GenerateMHTML(const base::FilePath& archives_dir);

+ virtual void GenerateMHTML(const base::FilePath& archives_dir,

+ int64_t archive_id);

fgorski 2016/03/30 01:43:30 Seems like there is a compilation error here somew

jianli 2016/03/31 21:02:42 Done.

// Callback for Generating MHTML.

void OnGenerateMHTMLDone(const GURL& url,