Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Side by Side Diff: components/offline_pages/offline_page_test_archiver.cc

Issue 1843893002: Support resaving offline page right after it is being deleted (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address feedback Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/offline_pages/offline_page_test_archiver.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/offline_pages/offline_page_test_archiver.h" 5 #include "components/offline_pages/offline_page_test_archiver.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/files/file_util.h" 8 #include "base/files/file_util.h"
9 #include "base/location.h" 9 #include "base/location.h"
10 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
(...skipping 14 matching lines...) Expand all
25 create_archive_called_(false), 25 create_archive_called_(false),
26 delayed_(false), 26 delayed_(false),
27 task_runner_(task_runner) {} 27 task_runner_(task_runner) {}
28 28
29 OfflinePageTestArchiver::~OfflinePageTestArchiver() { 29 OfflinePageTestArchiver::~OfflinePageTestArchiver() {
30 EXPECT_TRUE(create_archive_called_); 30 EXPECT_TRUE(create_archive_called_);
31 } 31 }
32 32
33 void OfflinePageTestArchiver::CreateArchive( 33 void OfflinePageTestArchiver::CreateArchive(
34 const base::FilePath& archives_dir, 34 const base::FilePath& archives_dir,
35 int64_t archive_id,
35 const CreateArchiveCallback& callback) { 36 const CreateArchiveCallback& callback) {
36 create_archive_called_ = true; 37 create_archive_called_ = true;
37 callback_ = callback; 38 callback_ = callback;
38 archives_dir_ = archives_dir; 39 archives_dir_ = archives_dir;
39 if (!delayed_) 40 if (!delayed_)
40 CompleteCreateArchive(); 41 CompleteCreateArchive();
41 } 42 }
42 43
43 void OfflinePageTestArchiver::CompleteCreateArchive() { 44 void OfflinePageTestArchiver::CompleteCreateArchive() {
44 DCHECK(!callback_.is_null()); 45 DCHECK(!callback_.is_null());
45 base::FilePath archive_path; 46 base::FilePath archive_path;
46 if (filename_.empty()) { 47 if (filename_.empty()) {
47 ASSERT_TRUE(base::CreateTemporaryFileInDir(archives_dir_, &archive_path)); 48 ASSERT_TRUE(base::CreateTemporaryFileInDir(archives_dir_, &archive_path));
48 } else { 49 } else {
49 archive_path = archives_dir_.Append(filename_); 50 archive_path = archives_dir_.Append(filename_);
50 // This step ensures the file is created and closed immediately. 51 // This step ensures the file is created and closed immediately.
51 base::File file(archive_path, base::File::FLAG_OPEN_ALWAYS); 52 base::File file(archive_path, base::File::FLAG_OPEN_ALWAYS);
52 } 53 }
53 observer_->SetLastPathCreatedByArchiver(archive_path); 54 observer_->SetLastPathCreatedByArchiver(archive_path);
54 task_runner_->PostTask(FROM_HERE, base::Bind(callback_, this, result_, url_, 55 task_runner_->PostTask(FROM_HERE, base::Bind(callback_, this, result_, url_,
55 archive_path, size_to_report_)); 56 archive_path, size_to_report_));
56 } 57 }
57 58
58 } // namespace offline_pages 59 } // namespace offline_pages
OLDNEW
« no previous file with comments | « components/offline_pages/offline_page_test_archiver.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698