Support resaving offline page right after it is being deleted

components/offline_pages/offline_page_model_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/offline_pages/offline_page_model.h"
 
 #include <stdint.h>
 #include <algorithm>
 #include <utility>
 
@@ skipping 470 matching lines @@
   PumpLoop();
 
   EXPECT_EQ(1UL, GetStore()->GetAllPages().size());
 
   // Fast forward to trigger the page deletion.
   FastForwardBy(OfflinePageModel::GetFinalDeletionDelayForTesting());
 
   EXPECT_EQ(0UL, GetStore()->GetAllPages().size());
 }
 
+TEST_F(OfflinePageModelTest, ResavePageAfterMarkingPageForDeletion) {

[fgorski, 2016/03/30 01:43:30]

SavePageAfter...

[jianli, 2016/03/31 21:02:42]

Done.

+  scoped_ptr<OfflinePageTestArchiver> archiver(BuildArchiver(
+      kTestUrl, OfflinePageArchiver::ArchiverResult::SUCCESSFULLY_CREATED));
+  model()->SavePage(
+      kTestUrl, kTestPageBookmarkId1, std::move(archiver),
+      base::Bind(&OfflinePageModelTest::OnSavePageDone, AsWeakPtr()));
+  PumpLoop();
+
+  // Mark the page for deletion.
+  model()->MarkPageForDeletion(
+      last_save_offline_id(),
+      base::Bind(&OfflinePageModelTest::OnDeletePageDone, AsWeakPtr()));
+  PumpLoop();
+
+  EXPECT_EQ(1UL, GetStore()->GetAllPages().size());
+
+  // Re-save the same page.
+  scoped_ptr<OfflinePageTestArchiver> archiver2(BuildArchiver(
+      kTestUrl, OfflinePageArchiver::ArchiverResult::SUCCESSFULLY_CREATED));
+  model()->SavePage(
+      kTestUrl, kTestPageBookmarkId1, std::move(archiver2),
+      base::Bind(&OfflinePageModelTest::OnSavePageDone, AsWeakPtr()));
+
+  // Fast forward to trigger the page cleanup.
+  FastForwardBy(OfflinePageModel::GetFinalDeletionDelayForTesting());
+
+  // The re-saved page should still exist.
+  const std::vector<OfflinePageItem>& offline_pages = model()->GetAllPages();
+  ASSERT_EQ(1UL, offline_pages.size());
+  EXPECT_EQ(kTestUrl, offline_pages[0].url);
+  EXPECT_EQ(kTestPageBookmarkId1, offline_pages[0].client_id);
+  EXPECT_EQ(kTestFileSize, offline_pages[0].file_size);
+  EXPECT_EQ(0, offline_pages[0].access_count);
+}
+
 TEST_F(OfflinePageModelTest, GetAllPagesStoreEmpty) {
   const std::vector<OfflinePageItem>& offline_pages = model()->GetAllPages();
 
   EXPECT_EQ(0UL, offline_pages.size());
 }
 
 TEST_F(OfflinePageModelTest, GetAllPagesStoreFailure) {
   GetStore()->set_test_scenario(
       OfflinePageTestStore::TestScenario::LOAD_FAILED);
   const std::vector<OfflinePageItem>& offline_pages = model()->GetAllPages();
@@ skipping 531 matching lines @@
   // Check if feature is correctly enabled by command-line flag.
   base::FeatureList::ClearInstanceForTesting();
   scoped_ptr<base::FeatureList> feature_list(new base::FeatureList);
   feature_list->InitializeFromCommandLine(
       offline_pages::kOfflinePagesBackgroundLoadingFeature.name, "");
   base::FeatureList::SetInstance(std::move(feature_list));
   EXPECT_TRUE(offline_pages::IsOfflinePagesBackgroundLoadingEnabled());
 }
 
 }  // namespace offline_pages