Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 1843863002: Avoid crash during PaintController::showDebugData() (Closed)

Created:
4 years, 8 months ago by Xianzhu
Modified:
4 years, 8 months ago
Reviewers:
pdr.
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, jbroman, Justin Novosad, Rik, Stephen Chennney, blink-reviews, f(malita), danakj+watch_chromium.org, kinuko+watch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid crash during PaintController::showDebugData() During merging, display items that have been moved to new places have null client. Avoid crash during PaintController::showDebugData() so that we can dump data during merge. Committed: https://crrev.com/bb7a91b5029ba5d3281b6aa272af89cebacd5320 Cr-Commit-Position: refs/heads/master@{#383880}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Xianzhu
4 years, 8 months ago (2016-03-29 23:00:24 UTC) #2
pdr.
On 2016/03/29 at 23:00:24, wangxianzhu wrote: > Now you're just showin' off :) LGTM
4 years, 8 months ago (2016-03-29 23:12:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1843863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1843863002/1
4 years, 8 months ago (2016-03-29 23:12:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-30 00:55:07 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 00:56:36 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb7a91b5029ba5d3281b6aa272af89cebacd5320
Cr-Commit-Position: refs/heads/master@{#383880}

Powered by Google App Engine
This is Rietveld 408576698